[jira] Commented: (WICKET-1340) Bogus LocalizedImageResource#isStateless()

["Marat Radchenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568461#action_12568461 ] 

Marat Radchenko commented on WICKET-1340:
-----------------------------------------

Just some thoughts:

1) Wrong assersion messages:
testEmpty -> "image withOUT resource reference should be statefull"
testResource -> "image with resource should be statefull"

2) Confusing javadoc in LocalizedImageResource#isStateless(). It says:
@return If it is stateless (if resource is null)

But current implementation checks if resource is NOT null.

3) I still doesn't understand why rr-less image is statefull. What's it's state? It doesn't have any variables defined -> no state. And image with rr has state - it contains knowledge about what exact resource this image references.
Look at your test case. Empty images has state, but non-empty image doesn't have state. This is very confusing.

So I strongly recommend you to take a deep breath and thing about this issue once more.

> Bogus LocalizedImageResource#isStateless()
> ------------------------------------------
>
>                 Key: WICKET-1340
>                 URL: https://issues.apache.org/jira/browse/WICKET-1340
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-final, 1.3.1
>            Reporter: Marat Radchenko
>            Assignee: Johan Compagner
>             Fix For: 1.3.2
>
>         Attachments: Image2Test.java, ImageTest.java
>
>
> Image without resource/resource reference should be stateless.
> Bug is located in LocalizedImageResource#isStateless(), which should read "return resourceReference == null;"
> Test case is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.