You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/15 18:24:49 UTC
[GitHub] codecov-io commented on issue #4565: [WIP] Move access permissions methods to security manager
codecov-io commented on issue #4565: [WIP] Move access permissions methods to security manager
URL: https://github.com/apache/incubator-superset/pull/4565#issuecomment-373476840
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=h1) Report
> Merging [#4565](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/36fa6cd7df24451ccc89001ab1d0a0f9592e67cf?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4565 +/- ##
==========================================
- Coverage 71.19% 71.18% -0.02%
==========================================
Files 189 189
Lines 14843 14848 +5
Branches 1088 1088
==========================================
+ Hits 10568 10569 +1
- Misses 4272 4276 +4
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4565/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.26% <0%> (-0.1%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/4565/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `66.43% <100%> (+8.75%)` | :arrow_up: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/4565/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `76.92% <44.87%> (-21.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4565/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.17% <62.5%> (-0.03%)` | :arrow_down: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4565/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.16% <0%> (-0.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=footer). Last update [36fa6cd...ba3009f](https://codecov.io/gh/apache/incubator-superset/pull/4565?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services