You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/03/03 14:02:20 UTC
Re: Review Request 56666: Added a HMAC SHA256 generator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56666/
-----------------------------------------------------------
(Updated March 3, 2017, 3:02 p.m.)
Review request for mesos, Alexander Rojas and Greg Mann.
Changes
-------
Addressed issues.
Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001
Repository: mesos
Description
-------
HMAC SHA256 can be used to create or verify message signatures.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/utilities.hpp c2f64a91a505675d568ddf5aa081125e4e32fe17
3rdparty/libprocess/src/ssl/utilities.cpp 8aec613312eee3dd11d9df8c3828a5185407e073
Diff: https://reviews.apache.org/r/56666/diff/4/
Changes: https://reviews.apache.org/r/56666/diff/3-4/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 56666: Added a HMAC SHA256 generator.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56666/#review168546
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 8, 2017, 2:11 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56666/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 2:11 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Greg Mann.
>
>
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
>
>
> Repository: mesos
>
>
> Description
> -------
>
> HMAC SHA256 can be used to create or verify message signatures.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/utilities.hpp c2f64a91a505675d568ddf5aa081125e4e32fe17
> 3rdparty/libprocess/src/ssl/utilities.cpp 8aec613312eee3dd11d9df8c3828a5185407e073
>
>
> Diff: https://reviews.apache.org/r/56666/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 56666: Added a HMAC SHA256 generator.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56666/
-----------------------------------------------------------
(Updated March 8, 2017, 3:11 p.m.)
Review request for mesos, Alexander Rojas and Greg Mann.
Changes
-------
Addressed issues.
Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001
Repository: mesos
Description
-------
HMAC SHA256 can be used to create or verify message signatures.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/utilities.hpp c2f64a91a505675d568ddf5aa081125e4e32fe17
3rdparty/libprocess/src/ssl/utilities.cpp 8aec613312eee3dd11d9df8c3828a5185407e073
Diff: https://reviews.apache.org/r/56666/diff/6/
Changes: https://reviews.apache.org/r/56666/diff/5-6/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 56666: Added a HMAC SHA256 generator.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56666/#review168184
-----------------------------------------------------------
3rdparty/libprocess/src/ssl/utilities.cpp
Lines 363 (patched)
<https://reviews.apache.org/r/56666/#comment240349>
if reason is nullptr the error shows up as "HMAC failed: " which is weird.
how about
```
return Error(
"HMAC failed" + (reason == nultpr ? "" : ": " + std::string(reason)));
```
- Vinod Kone
On March 7, 2017, 3:34 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56666/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 3:34 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Greg Mann.
>
>
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
>
>
> Repository: mesos
>
>
> Description
> -------
>
> HMAC SHA256 can be used to create or verify message signatures.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/utilities.hpp c2f64a91a505675d568ddf5aa081125e4e32fe17
> 3rdparty/libprocess/src/ssl/utilities.cpp 8aec613312eee3dd11d9df8c3828a5185407e073
>
>
> Diff: https://reviews.apache.org/r/56666/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 56666: Added a HMAC SHA256 generator.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56666/
-----------------------------------------------------------
(Updated March 7, 2017, 4:34 p.m.)
Review request for mesos, Alexander Rojas and Greg Mann.
Changes
-------
Fixed a typo.
Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001
Repository: mesos
Description
-------
HMAC SHA256 can be used to create or verify message signatures.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/utilities.hpp c2f64a91a505675d568ddf5aa081125e4e32fe17
3rdparty/libprocess/src/ssl/utilities.cpp 8aec613312eee3dd11d9df8c3828a5185407e073
Diff: https://reviews.apache.org/r/56666/diff/5/
Changes: https://reviews.apache.org/r/56666/diff/4-5/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 56666: Added a HMAC SHA256 generator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56666/#review168036
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/ssl/utilities.hpp
Lines 115 (patched)
<https://reviews.apache.org/r/56666/#comment240045>
s/hase/hash/
- Greg Mann
On March 3, 2017, 2:02 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56666/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Greg Mann.
>
>
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
>
>
> Repository: mesos
>
>
> Description
> -------
>
> HMAC SHA256 can be used to create or verify message signatures.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/utilities.hpp c2f64a91a505675d568ddf5aa081125e4e32fe17
> 3rdparty/libprocess/src/ssl/utilities.cpp 8aec613312eee3dd11d9df8c3828a5185407e073
>
>
> Diff: https://reviews.apache.org/r/56666/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>