You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by robdouglas <gi...@git.apache.org> on 2014/11/14 18:19:17 UTC
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
GitHub user robdouglas opened a pull request:
https://github.com/apache/incubator-streams/pull/130
STREAMS-216 | Identifying Stream information in JMX monitoring Beans
Identifying Stream information in JMX monitoring Beans
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robdouglas/incubator-streams STREAMS-216
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit b9f3519bf18213e5a9b343b1fba25a4b13f2ce3b
Author: Robert Douglas <rd...@w2ogroup.com>
Date: 2014-11-11T22:26:23Z
STREAMS-216 | Updated the broadcast object to contain a streams ID which will make it easier to identify which Stream the beans belong to
commit 966b12b388b2a95a143a89094a7298bceb3539a4
Author: Robert Douglas <rd...@w2ogroup.com>
Date: 2014-11-13T16:14:17Z
Merge branch 'master' into STREAMS-216
commit 9a77a8f7c29ccffc8a71b1a4d7974e7904d98651
Author: Robert Douglas <rd...@w2ogroup.com>
Date: 2014-11-13T18:46:56Z
Merge branch 'master' into STREAMS-216
Conflicts:
streams-monitoring/src/main/java/org/apache/streams/monitoring/tasks/BroadcastMonitorThread.java
streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
commit fb8f9d209bf604a3b2127e22441e54b8e3259ad7
Author: Robert Douglas <rd...@w2ogroup.com>
Date: 2014-11-14T17:17:23Z
STREAMS-216 | All JMX monitoring beans now include identifying information and the time that the stream was started
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on the pull request:
https://github.com/apache/incubator-streams/pull/130#issuecomment-63509239
Responded to code review feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/130#discussion_r20465367
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java ---
@@ -119,7 +129,7 @@ public void run() {
@Override
public StreamBuilder newPerpetualStream(String id, StreamsProvider provider) {
validateId(id);
- this.providers.put(id, new StreamComponent(id, provider, true));
+ this.providers.put(id, new StreamComponent(id, provider, true, streamConfig));
--- End diff --
I would prefer to see the components given org.apache.streams.config.StreamsConfiguration instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/130#issuecomment-63704309
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on the pull request:
https://github.com/apache/incubator-streams/pull/130#issuecomment-63503329
```Tests run: 92, Failures: 4, Errors: 72, Skipped: 1
Failed tests:
DatumStatusCounterTest.testConstructor:59->Assert.fail:88 Constructor Threw Exception : javax.management.InstanceAlreadyExistsException: org.apache.streams.local:type=DatumCounter,name=test_id,identifier=Unknown_Stream,startedAt=-1
StreamsTaskCounterTest.testConstructor:57->Assert.fail:88 Constructor threw error : javax.management.InstanceAlreadyExistsException: org.apache.streams.local:type=StreamsTaskCounter,name=test_id,identifier=null,startedAt=-1
ThroughputQueueSingleThreadTest.testMultipleMBeanRegistrations:238->Assert.fail:88 Failed to register MXBean : Format specifier 's'
ThroughputQueueSingleThreadTest.testMBeanRegistration:217->Assert.fail:88 Failed to register MXBean : Format specifier 's'
Tests in error:
LocalStreamBuilderTest.testBasicLinearStream1:132->linearStreamNonParallel:183->removeRegisteredMBeans:93 » MissingFormatArgument
LocalStreamBuilderTest.testStreamIdValidations:110 » NullPointer
LocalStreamBuilderTest.testBasicLinearStream2:137->linearStreamNonParallel:183->removeRegisteredMBeans:93 » MissingFormatArgument
LocalStreamBuilderTest.testBasicMergeStream:246->removeRegisteredMBeans:93 » MissingFormatArgument
LocalStreamBuilderTest.testParallelLinearStream1:220->removeRegisteredMBeans:93 » MissingFormatArgument
...
```
There are failed test in your pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/130#discussion_r20474623
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java ---
@@ -119,7 +129,7 @@ public void run() {
@Override
public StreamBuilder newPerpetualStream(String id, StreamsProvider provider) {
validateId(id);
- this.providers.put(id, new StreamComponent(id, provider, true));
+ this.providers.put(id, new StreamComponent(id, provider, true, streamConfig));
--- End diff --
However, I think its best not to expand the scope of this story.
So +1, and I'll open a new story to consolidate all usage of stream-wide configuration options into StreamsConfiguration
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---