You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/01/13 01:09:01 UTC
[jira] [Commented] (IMPALA-7833) Audit and fix other string
builtins for long string handling
[ https://issues.apache.org/jira/browse/IMPALA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263802#comment-17263802 ]
ASF subversion and git services commented on IMPALA-7833:
---------------------------------------------------------
Commit e638bc04a258e123e1a2819bb4b5637ef40076c3 in impala's branch refs/heads/3.x from Akos Kovacs
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e638bc0 ]
IMPALA-7833 Audit and fix string builtins for long string handling
Some string built-in functions could crash impalad,
in case the result was longer than 1 gig max size.
Added some overflow checks.
Overflow error messages modified not to hard code max size.
Testing:
* Added some backend tests to cover overflow check
* Ran core tests
Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49
Reviewed-on: http://gerrit.cloudera.org:8080/15864
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
(cherry picked from commit 5e72ca546ec3dd83a11de5d1905db50807544c5e)
> Audit and fix other string builtins for long string handling
> ------------------------------------------------------------
>
> Key: IMPALA-7833
> URL: https://issues.apache.org/jira/browse/IMPALA-7833
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.11.0, Impala 3.0, Impala 3.1.0
> Reporter: Tim Armstrong
> Assignee: Akos Kovacs
> Priority: Major
> Labels: crash, ramp-up
> Fix For: Impala 4.0
>
>
> Following on from IMPALA-7822, there are some other string builtins that seem to follow the same pattern of having a string size overflow an int passed into the StringVal constructor. I think in some cases we get lucky and it works out, but others it seems possible to crash given the right input values.
> Here are some examples of cases where we can hit such bugs:
> {noformat}
> select lpad('foo', 17179869184 , ' ');
> select rpad('foo', 17179869184 , ' ');
> select space(17179869184 );
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org