You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/02/23 02:37:17 UTC
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18266
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
[PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
This revisits the list of excluded components for
impala-minimal-s3a-aws-sdk.jar. As new components are added
in the AWS SDK bundle, this build code gets out of date and
doesn't exclude the new things. This adds exclusions for
more services in the AWS SDK bundle. It also excludes the
models, which are JSON files that don't seem to be in use.
Size of impala-minimal-s3a-aws-sdk.jar:
Before: 89.7MB
After: 13.6MB
Testing:
- S3 core tests pass
Change-Id: I8092b159d15836d40ef34d390698921216342b5b
---
M java/shaded-deps/s3a-aws-sdk/pom.xml
1 file changed, 145 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/18266/1
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18266
to look at the new patch set (#3).
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
[PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
This revisits the list of excluded components for
impala-minimal-s3a-aws-sdk.jar. As new components are added
in the AWS SDK bundle, this build code gets out of date and
doesn't exclude the new things. This adds exclusions for
more services in the AWS SDK bundle. It also excludes the
models, which are JSON files that don't seem to be in use.
Size of impala-minimal-s3a-aws-sdk.jar:
Before: 161.8MB
After: 17.5MB
Testing:
- S3 core tests pass
Change-Id: I8092b159d15836d40ef34d390698921216342b5b
---
M java/shaded-deps/s3a-aws-sdk/pom.xml
1 file changed, 190 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/18266/3
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18266 )
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12473/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 21:09:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18266 )
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12472/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 21:09:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18266 )
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18266/3/java/shaded-deps/s3a-aws-sdk/pom.xml
File java/shaded-deps/s3a-aws-sdk/pom.xml:
http://gerrit.cloudera.org:8080/#/c/18266/3/java/shaded-deps/s3a-aws-sdk/pom.xml@56
PS3, Line 56: <excludes>
Is there any way we could exclude everything then include only the things we need?
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 21:39:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18266
to look at the new patch set (#2).
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
[PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
This revisits the list of excluded components for
impala-minimal-s3a-aws-sdk.jar. As new components are added
in the AWS SDK bundle, this build code gets out of date and
doesn't exclude the new things. This adds exclusions for
more services in the AWS SDK bundle. It also excludes the
models, which are JSON files that don't seem to be in use.
Size of impala-minimal-s3a-aws-sdk.jar:
Before: 161.8MB
After: 17.5MB
Testing:
- S3 core tests pass
Change-Id: I8092b159d15836d40ef34d390698921216342b5b
---
M java/shaded-deps/s3a-aws-sdk/pom.xml
1 file changed, 191 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/18266/2
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18266 )
Change subject: [PROTOTYPE] IMPALA-11125: Revisit the contents of impala-minimal-s3a-aws-sdk jar
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10207/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8092b159d15836d40ef34d390698921216342b5b
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 03:01:50 +0000
Gerrit-HasComments: No