You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by Mike Percy <mp...@apache.org> on 2017/05/03 02:42:43 UTC
Thinking about renaming TabletPeer
It would be nice to rename TabletPeer. What do you guys think? It's kind of
a confusingly named class.
I think a better class name would be ReplicatedTablet or TabletReplica.
Mike
Re: Thinking about renaming TabletPeer
Posted by Dan Burkert <da...@apache.org>.
> none seems better than TabletReplica IMO.
+ 1
On Wed, May 3, 2017 at 1:05 PM, <da...@gmail.com> wrote:
> none seems better than TabletReplica IMO.
>
Re: Thinking about renaming TabletPeer
Posted by Mike Percy <mp...@apache.org>.
FYI the TabletPeer -> TabletReplica rename patch just landed:
https://github.com/apache/kudu/commit/7f72105b79b36480d132e0ed10f4cc
7fbabd6dca
It touched a lot of files so you might want to rebase soon to avoid
conflicts.
Thanks,
Mike
On Thu, May 4, 2017 at 1:48 PM, Mike Percy <mp...@apache.org> wrote:
> I posted a CR to rename TabletPeer to TabletReplica here:
> https://gerrit.cloudera.org/#/c/6794/
>
> On Wed, May 3, 2017 at 1:35 PM, Hao Hao <ha...@cloudera.com> wrote:
>
>> +1 on TabletReplica.
>>
>> On Wed, May 3, 2017 at 1:27 PM, William Berkeley <wd...@gmail.com>
>> wrote:
>>
>> > +1 TabletReplica
>> > On Wed, May 3, 2017 at 13:11 Andrew Wong <aw...@cloudera.com> wrote:
>> >
>> > > I agree, TabletReplica seems clear.
>> > >
>> > >
>> > > On Wed, May 3, 2017 at 1:05 PM <da...@gmail.com> wrote:
>> > >
>> > > > none seems better than TabletReplica IMO.
>> > > >
>> > >
>> >
>>
>
>
Re: Thinking about renaming TabletPeer
Posted by Mike Percy <mp...@apache.org>.
I posted a CR to rename TabletPeer to TabletReplica here:
https://gerrit.cloudera.org/#/c/6794/
On Wed, May 3, 2017 at 1:35 PM, Hao Hao <ha...@cloudera.com> wrote:
> +1 on TabletReplica.
>
> On Wed, May 3, 2017 at 1:27 PM, William Berkeley <wd...@gmail.com>
> wrote:
>
> > +1 TabletReplica
> > On Wed, May 3, 2017 at 13:11 Andrew Wong <aw...@cloudera.com> wrote:
> >
> > > I agree, TabletReplica seems clear.
> > >
> > >
> > > On Wed, May 3, 2017 at 1:05 PM <da...@gmail.com> wrote:
> > >
> > > > none seems better than TabletReplica IMO.
> > > >
> > >
> >
>
Re: Thinking about renaming TabletPeer
Posted by Hao Hao <ha...@cloudera.com>.
+1 on TabletReplica.
On Wed, May 3, 2017 at 1:27 PM, William Berkeley <wd...@gmail.com>
wrote:
> +1 TabletReplica
> On Wed, May 3, 2017 at 13:11 Andrew Wong <aw...@cloudera.com> wrote:
>
> > I agree, TabletReplica seems clear.
> >
> >
> > On Wed, May 3, 2017 at 1:05 PM <da...@gmail.com> wrote:
> >
> > > none seems better than TabletReplica IMO.
> > >
> >
>
Re: Thinking about renaming TabletPeer
Posted by William Berkeley <wd...@gmail.com>.
+1 TabletReplica
On Wed, May 3, 2017 at 13:11 Andrew Wong <aw...@cloudera.com> wrote:
> I agree, TabletReplica seems clear.
>
>
> On Wed, May 3, 2017 at 1:05 PM <da...@gmail.com> wrote:
>
> > none seems better than TabletReplica IMO.
> >
>
Re: Thinking about renaming TabletPeer
Posted by Andrew Wong <aw...@cloudera.com>.
I agree, TabletReplica seems clear.
On Wed, May 3, 2017 at 1:05 PM <da...@gmail.com> wrote:
> none seems better than TabletReplica IMO.
>
Thinking about renaming TabletPeer
Posted by da...@gmail.com.
none seems better than TabletReplica IMO.
Re: Thinking about renaming TabletPeer
Posted by Mike Percy <mp...@apache.org>.
HostedReplica? LocalReplica? HostedTabletReplica?
On Wed, May 3, 2017 at 12:37 PM, Todd Lipcon <to...@cloudera.com> wrote:
> brainstorming: HostedTablet?
>
> On Wed, May 3, 2017 at 12:36 PM, Alexey Serbin <as...@cloudera.com>
> wrote:
>
> > TabletInstance, TabletClone? Not sure it's any better than
> TabletReplica.
> >
> > Using thesaurus I came up with TabletDoppelganger, but I don't think that
> > could be any popular :)
> >
> >
> > Best regards,
> >
> > Alexey
> >
> >
> >
> > On 5/3/17 10:24 AM, Todd Lipcon wrote:
> >
> >> Sure, I think TabletReplica could be more clear. ReplicatedTablet seems
> >> not
> >> quite right, since it's also used for non-replicated (1-replica) cases.
> >>
> >> I sort of feel like there's some better name out there, but can't quite
> >> think of one. Anyone else have some ideas to brainstorm?
> >>
> >> -Todd
> >>
> >> On Tue, May 2, 2017 at 7:42 PM, Mike Percy <mp...@apache.org> wrote:
> >>
> >> It would be nice to rename TabletPeer. What do you guys think? It's kind
> >>> of
> >>> a confusingly named class.
> >>>
> >>> I think a better class name would be ReplicatedTablet or TabletReplica.
> >>>
> >>> Mike
> >>>
> >>>
> >>
> >>
> >
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>
Re: Thinking about renaming TabletPeer
Posted by Todd Lipcon <to...@cloudera.com>.
brainstorming: HostedTablet?
On Wed, May 3, 2017 at 12:36 PM, Alexey Serbin <as...@cloudera.com> wrote:
> TabletInstance, TabletClone? Not sure it's any better than TabletReplica.
>
> Using thesaurus I came up with TabletDoppelganger, but I don't think that
> could be any popular :)
>
>
> Best regards,
>
> Alexey
>
>
>
> On 5/3/17 10:24 AM, Todd Lipcon wrote:
>
>> Sure, I think TabletReplica could be more clear. ReplicatedTablet seems
>> not
>> quite right, since it's also used for non-replicated (1-replica) cases.
>>
>> I sort of feel like there's some better name out there, but can't quite
>> think of one. Anyone else have some ideas to brainstorm?
>>
>> -Todd
>>
>> On Tue, May 2, 2017 at 7:42 PM, Mike Percy <mp...@apache.org> wrote:
>>
>> It would be nice to rename TabletPeer. What do you guys think? It's kind
>>> of
>>> a confusingly named class.
>>>
>>> I think a better class name would be ReplicatedTablet or TabletReplica.
>>>
>>> Mike
>>>
>>>
>>
>>
>
--
Todd Lipcon
Software Engineer, Cloudera
Re: Thinking about renaming TabletPeer
Posted by Alexey Serbin <as...@cloudera.com>.
TabletInstance, TabletClone? Not sure it's any better than TabletReplica.
Using thesaurus I came up with TabletDoppelganger, but I don't think
that could be any popular :)
Best regards,
Alexey
On 5/3/17 10:24 AM, Todd Lipcon wrote:
> Sure, I think TabletReplica could be more clear. ReplicatedTablet seems not
> quite right, since it's also used for non-replicated (1-replica) cases.
>
> I sort of feel like there's some better name out there, but can't quite
> think of one. Anyone else have some ideas to brainstorm?
>
> -Todd
>
> On Tue, May 2, 2017 at 7:42 PM, Mike Percy <mp...@apache.org> wrote:
>
>> It would be nice to rename TabletPeer. What do you guys think? It's kind of
>> a confusingly named class.
>>
>> I think a better class name would be ReplicatedTablet or TabletReplica.
>>
>> Mike
>>
>
>
Re: Thinking about renaming TabletPeer
Posted by Todd Lipcon <to...@cloudera.com>.
Sure, I think TabletReplica could be more clear. ReplicatedTablet seems not
quite right, since it's also used for non-replicated (1-replica) cases.
I sort of feel like there's some better name out there, but can't quite
think of one. Anyone else have some ideas to brainstorm?
-Todd
On Tue, May 2, 2017 at 7:42 PM, Mike Percy <mp...@apache.org> wrote:
> It would be nice to rename TabletPeer. What do you guys think? It's kind of
> a confusingly named class.
>
> I think a better class name would be ReplicatedTablet or TabletReplica.
>
> Mike
>
--
Todd Lipcon
Software Engineer, Cloudera