You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2011/07/13 20:18:59 UTC

[jira] [Closed] (THRIFT-1225) TCompactProtocol for PHP

     [ https://issues.apache.org/jira/browse/THRIFT-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1225.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
         Assignee: Dave Watson

I did a very cursory review and this looks faithful. I'd really like to have tests, but we can do those later, I guess. I committed the patch. Thanks Dave!

> TCompactProtocol for PHP
> ------------------------
>
>                 Key: THRIFT-1225
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1225
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>             Fix For: 0.7
>
>         Attachments: thrift-1225.patch
>
>
> A TCompactProtocol implementation for PHP.  Similar to the Python version.  
> Except the I64 stuff. I64 doesn't work on 32bit PHP, it uses two 32bit ints instead and a bunch of bit fiddling.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira