You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2025/09/09 08:58:30 UTC

[PR] Improve migration consistency check to reflect storage unit maxPoolSize dynamically [shardingsphere]

sandynz opened a new pull request, #36507:
URL: https://github.com/apache/shardingsphere/pull/36507

   
   Changes proposed in this pull request:
     - Improve migration consistency check to reflect storage unit maxPoolSize dynamically
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improve migration consistency check to reflect storage unit maxPoolSize dynamically [shardingsphere]

Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #36507:
URL: https://github.com/apache/shardingsphere/pull/36507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improve migration consistency check to reflect storage unit maxPoolSize dynamically [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #36507:
URL: https://github.com/apache/shardingsphere/pull/36507#issuecomment-3520223162

   Usage:
   Migration consistency check will build ShardingSphereDataSource with data source configuration from migration job configuration, including `maxPoolSize` data source property.
   If `maxPoolSize` is not enough for consistency check (there's get connection error message in `SHOW MIGRATION CHECK STATUS ...`), then we can update `maxPoolSize` via `ALTER STORAGE UNIT ...`. And restart consistency check job to make `maxPoolSize` take effect.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org