You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Denes Arvay <de...@cloudera.com> on 2016/09/02 12:48:47 UTC
Re: Review Request 50562: Patch for FLUME-2797 - SyslogTcpSource uses
Deprecated Class + Deprecate Syslog Source
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50562/
-----------------------------------------------------------
(Updated Sept. 2, 2016, 12:48 p.m.)
Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
Changes
-------
updated diff according to Mike's review
Bugs: FLUME-2797
https://issues.apache.org/jira/browse/FLUME-2797
Repository: flume-git
Description
-------
Patch for FLUME-2797 - SyslogTcpSource uses Deprecated Class + Deprecate SyslogTCPSource
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 185c00c
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 175bebb
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 10ef8d8
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java e5b7a06
Diff: https://reviews.apache.org/r/50562/diff/
Testing
-------
- checkstyle passes
- `flume-ng-core` tests pass
- 2 new tests added
Thanks,
Denes Arvay
Re: Review Request 50562: Patch for FLUME-2797 - SyslogTcpSource uses
Deprecated Class + Deprecate Syslog Source
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50562/#review148207
-----------------------------------------------------------
Ship it!
Ship It!
- Mike Percy
On Sept. 2, 2016, 5:48 a.m., Denes Arvay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50562/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 5:48 a.m.)
>
>
> Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
>
>
> Bugs: FLUME-2797
> https://issues.apache.org/jira/browse/FLUME-2797
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for FLUME-2797 - SyslogTcpSource uses Deprecated Class + Deprecate SyslogTCPSource
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 185c00c
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 175bebb
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 10ef8d8
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java e5b7a06
>
> Diff: https://reviews.apache.org/r/50562/diff/
>
>
> Testing
> -------
>
> - checkstyle passes
> - `flume-ng-core` tests pass
> - 2 new tests added
>
>
> Thanks,
>
> Denes Arvay
>
>
Re: Review Request 50562: Patch for FLUME-2797 - SyslogTcpSource uses
Deprecated Class + Deprecate Syslog Source
Posted by Balázs Donát Bessenyei <be...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50562/#review147653
-----------------------------------------------------------
Ship it!
Ship It!
- Bal�zs Don�t Bessenyei
On Sept. 2, 2016, 12:48 p.m., Denes Arvay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50562/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 12:48 p.m.)
>
>
> Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
>
>
> Bugs: FLUME-2797
> https://issues.apache.org/jira/browse/FLUME-2797
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for FLUME-2797 - SyslogTcpSource uses Deprecated Class + Deprecate SyslogTCPSource
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 185c00c
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 175bebb
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 10ef8d8
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java e5b7a06
>
> Diff: https://reviews.apache.org/r/50562/diff/
>
>
> Testing
> -------
>
> - checkstyle passes
> - `flume-ng-core` tests pass
> - 2 new tests added
>
>
> Thanks,
>
> Denes Arvay
>
>