You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2011/10/01 22:26:02 UTC

svn commit: r1178087 - in /maven/shared/trunk/maven-dependency-analyzer/src/test: java/org/apache/maven/shared/dependency/analyzer/ resources/jarWithXmlTransitiveDependency/ resources/jarWithXmlTransitiveDependency/src/ resources/jarWithXmlTransitiveDe...

Author: hboutemy
Date: Sat Oct  1 20:26:01 2011
New Revision: 1178087

URL: http://svn.apache.org/viewvc?rev=1178087&view=rev
Log:
[MSHARED-47] added unit test to show wrong xml-apis dependency analysis: forgot files

Added:
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml   (with props)
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/
    maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java   (with props)
Modified:
    maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java

Modified: maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java?rev=1178087&r1=1178086&r2=1178087&view=diff
==============================================================================
--- maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java (original)
+++ maven/shared/trunk/maven-dependency-analyzer/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java Sat Oct  1 20:26:01 2011
@@ -163,7 +163,7 @@ public class DefaultProjectDependencyAna
         assertEquals( expectedAnalysis, actualAnalysis );
     }
 
-    public void testJarWithXxmlTransitiveDependency()
+    public void testJarWithXmlTransitiveDependency()
         throws TestToolsException, ProjectDependencyAnalyzerException
     {
         compileProject( "jarWithXmlTransitiveDependency/pom.xml" );

Added: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml?rev=1178087&view=auto
==============================================================================
--- maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml (added)
+++ maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml Sat Oct  1 20:26:01 2011
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+<project
+	xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
+>
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>org.apache.maven.shared.dependency-analyzer.tests</groupId>
+  <artifactId>jarWithXercesDependencies</artifactId>
+  <version>1.0</version>
+  <packaging>jar</packaging>
+
+  <dependencies>
+    <dependency>
+      <groupId>dom4j</groupId>
+      <artifactId>dom4j</artifactId>
+      <version>1.6.1</version>
+    </dependency>
+  </dependencies>
+</project>

Propchange: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Propchange: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/pom.xml
------------------------------------------------------------------------------
    svn:mime-type = text/plain

Added: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java?rev=1178087&view=auto
==============================================================================
--- maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java (added)
+++ maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java Sat Oct  1 20:26:01 2011
@@ -0,0 +1,42 @@
+package jarWithXmlTransitiveDependency;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.dom4j.Text;
+import org.xml.sax.Parser;
+
+/**
+ * Dependency on dom4j gives xml-apis transitive dependency, which contains SAX Parser class. But SAX Parser is available in
+ * JDK: no need to declare a direct dependency.
+ * 
+ */
+public class Project
+{
+    public Text text;
+    
+    public Parser parser;
+
+    // constructors -----------------------------------------------------------
+
+    public Project()
+    {
+        // no op
+    }
+}

Propchange: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Propchange: maven/shared/trunk/maven-dependency-analyzer/src/test/resources/jarWithXmlTransitiveDependency/src/main/java/jarWithXmlTransitiveDependency/Project.java
------------------------------------------------------------------------------
    svn:mime-type = text/plain