You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by combineads <gi...@git.apache.org> on 2015/12/23 10:08:16 UTC
[GitHub] tajo pull request: TAJO-2031: Provides a simple contribution scrip...
GitHub user combineads opened a pull request:
https://github.com/apache/tajo/pull/920
TAJO-2031: Provides a simple contribution script for some beginner.
It is a simple shell script for some beginner developers should be to contribute the Tajo project in the github.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/combineads/tajo TAJO-2031
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #920
----
commit d3ffcabb44539427532da20678c788e867098800
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2015-12-16T05:26:27Z
Remove unused import class
commit 31637c41cdcebbccc5854de8a131e5cd86f1c4a3
Author: combineads <co...@combineads.co.kr>
Date: 2015-12-16T05:57:01Z
Merge remote-tracking branch 'upstream/master'
commit 463dd93c0dcc0b5f022308ad2adc3da7068c4441
Author: combineads <co...@combineads.co.kr>
Date: 2015-12-18T02:35:32Z
Merge remote-tracking branch 'upstream/master'
commit ee1a52587e28f474876aed086ffc4ec63ac99956
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2015-12-23T09:06:21Z
TAJO-2031: Provides a simple contribution script for some beginner.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2031: Provides a simple contribution scrip...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/920#issuecomment-168564137
Hi @combineads
Thank you for your contribution. But I don't sense that ``sync`` is right name for contribution. If you create a document file instead of shell script file, contributors will know that it is a guide for contribution by file name and readability of github would be better in comparison with shell script. I recommend the file name is ``CONTRIBUTING.md``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2031: Provides a simple contribution scrip...
Posted by combineads <gi...@git.apache.org>.
Github user combineads closed the pull request at:
https://github.com/apache/tajo/pull/920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2031: Provides a simple contribution scrip...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/920#issuecomment-171149521
Sorry @combineads, I thought about it again. Tajo already provides some documents for contributing as follows. https://cwiki.apache.org/confluence/display/TAJO/How+to+Contribute+Codes+to+Tajo.
If possible, could you update existing wiki page? If you don't have a wiki account, you can request it to dev@tajo.apache.org.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---