You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/12 19:30:02 UTC

[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #146: Regenerate documentation images using pekko implementations.

pjfanning commented on code in PR #146:
URL: https://github.com/apache/incubator-pekko-http/pull/146#discussion_r1192730466


##########
docs/src/test/java/docs/http/javadsl/server/BlockingInHttpExamples.java:
##########
@@ -60,7 +61,7 @@ void blockingHttpDedicatedDispatcher() {
         //#blocking-example-in-dedicated-dispatcher
         // GOOD (the blocking is now isolated onto a dedicated dispatcher):
         final Route routes = post(() -> {
-            final MessageDispatcher dispatcher = system.dispatchers().lookup("my-blocking-dispatcher");

Review Comment:
   the existing code compiles for me - why change it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org