You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/04 19:50:16 UTC
Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Repository: mesos
Description
-------
These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
Diffs
-----
3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
Diff: https://reviews.apache.org/r/39948/diff/
Testing
-------
None. Comment change only.
Thanks,
Joseph Wu
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/#review105210
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十一月 4, 2015, 6:50 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39948/
> -----------------------------------------------------------
>
> (Updated 十一月 4, 2015, 6:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
>
> Diff: https://reviews.apache.org/r/39948/diff/
>
>
> Testing
> -------
>
> None. Comment change only.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/#review107633
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 20, 2015, 7:16 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39948/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 7:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3864
> https://issues.apache.org/jira/browse/MESOS-3864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 8fa0594b671969c2713d1b361f2dbbb07d25b3a8
>
> Diff: https://reviews.apache.org/r/39948/diff/
>
>
> Testing
> -------
>
> None. Comment change only.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/#review107571
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Nov. 20, 2015, 8:16 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39948/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 8:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3864
> https://issues.apache.org/jira/browse/MESOS-3864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 8fa0594b671969c2713d1b361f2dbbb07d25b3a8
>
> Diff: https://reviews.apache.org/r/39948/diff/
>
>
> Testing
> -------
>
> None. Comment change only.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/
-----------------------------------------------------------
(Updated Nov. 20, 2015, 11:16 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3864
https://issues.apache.org/jira/browse/MESOS-3864
Repository: mesos
Description
-------
These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 8fa0594b671969c2713d1b361f2dbbb07d25b3a8
Diff: https://reviews.apache.org/r/39948/diff/
Testing
-------
None. Comment change only.
Thanks,
Joseph Wu
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 2:23 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-3864
https://issues.apache.org/jira/browse/MESOS-3864
Repository: mesos
Description
-------
These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
Diffs
-----
3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
Diff: https://reviews.apache.org/r/39948/diff/
Testing
-------
None. Comment change only.
Thanks,
Joseph Wu
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 2:11 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-3820
https://issues.apache.org/jira/browse/MESOS-3820
Repository: mesos
Description
-------
These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
Diffs
-----
3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
Diff: https://reviews.apache.org/r/39948/diff/
Testing
-------
None. Comment change only.
Thanks,
Joseph Wu
Re: Review Request 39948: Remove some undocumented,
commented-out code within libprocess.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/#review105129
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Nov. 4, 2015, 6:50 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39948/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 6:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These are remnants of commented-out code, dating back to when libprocess was originally open-sourced.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313
>
> Diff: https://reviews.apache.org/r/39948/diff/
>
>
> Testing
> -------
>
> None. Comment change only.
>
>
> Thanks,
>
> Joseph Wu
>
>