You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2016/06/18 05:26:05 UTC

[jira] [Commented] (OFBIZ-7272) Enforce noninstantiability with a private constructor to all Utility classes

    [ https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337556#comment-15337556 ] 

Jacques Le Roux commented on OFBIZ-7272:
----------------------------------------

This is a good initiative, thanks guys!

> Enforce noninstantiability with a private constructor to all Utility classes
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-7272
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7272
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>         Attachments: OFBIZ-7272.patch
>
>
> I have discusses this in past on mailing list, that Utility, helper, worker classes which contains only static methods should not be instantiable. Also we can restrict it by adding a private constructor.
> Currently OFBiz has many such classes which should have private constructor. Identify all the *Worker.java, *.Helper.java, and *Util.java which do not have any non static method/member are eligible for having a private constructor.
> Reference why we should do this : http://www.informit.com/articles/article.aspx?p=1216151&seqNum=4



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)