You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/01/28 02:57:11 UTC
[jira] [Created] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Update metrics numOpenConnections and callQueueLen directly in HBaseServer
--------------------------------------------------------------------------
Key: HBASE-5297
URL: https://issues.apache.org/jira/browse/HBASE-5297
Project: HBase
Issue Type: Improvement
Components: metrics
Reporter: Scott Chen
Assignee: Scott Chen
Priority: Minor
Attachments: HBASE-5297.D1509.1.patch
It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195419#comment-13195419 ]
Phabricator commented on HBASE-5297:
------------------------------------
tedyu has commented on the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java:1275 A short javadoc would be helpful for this method.
I think adding a BlockingQueue<Call> parameter for the actual call queue being updated would make this method simpler - only one set() call is needed.
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java:1277 This should be priorityCallQueue, right ?
REVISION DETAIL
https://reviews.facebook.net/D1509
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5297:
------------------------------
Status: Patch Available (was: Open)
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5297:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196714#comment-13196714 ]
Hudson commented on HBASE-5297:
-------------------------------
Integrated in HBase-TRUNK #2648 (See [https://builds.apache.org/job/HBase-TRUNK/2648/])
HBASE-5297 Update metrics numOpenConnections and callQueueLen directly in HBaseServer (Scott Chen)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196584#comment-13196584 ]
Zhihong Yu commented on HBASE-5297:
-----------------------------------
Integrated to TRUNK.
Thanks for the patch Scott.
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195426#comment-13195426 ]
Phabricator commented on HBASE-5297:
------------------------------------
sc has commented on the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java:1277 good catch
REVISION DETAIL
https://reviews.facebook.net/D1509
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195401#comment-13195401 ]
Scott Chen commented on HBASE-5297:
-----------------------------------
Zhihong: Thanks for pointing this out. I will fix the problem.
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5297.D1509.1.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195436#comment-13195436 ]
Hadoop QA commented on HBASE-5297:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512286/HBASE-5297.D1509.2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -140 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestAtomicOperation
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/862//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/862//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/862//console
This message is automatically generated.
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272660#comment-13272660 ]
Phabricator commented on HBASE-5297:
------------------------------------
sc has closed the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
REVISION DETAIL
https://reviews.facebook.net/D1509
To: dhruba, tedyu, JIRA, sc
Cc: tedyu, sc
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5297:
-------------------------------
Attachment: HBASE-5297.D1509.3.patch
sc updated the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
Reviewers: dhruba, tedyu, JIRA
Addressed Ted's comments
REVISION DETAIL
https://reviews.facebook.net/D1509
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195395#comment-13195395 ]
Zhihong Yu commented on HBASE-5297:
-----------------------------------
I think RpcServer.java might have been dropped from the patch.
That's why I got the following compilation error:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project hbase: Compilation failure
[ERROR] /Users/zhihyu/trunk-hbase/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java:[250,16] org.apache.hadoop.hbase.ipc.WritableRpcEngine.Server is not abstract and does not override abstract method getCallQueueLen() in org.apache.hadoop.hbase.ipc.RpcServer
{code}
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5297.D1509.1.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5297:
-------------------------------
Attachment: HBASE-5297.D1509.1.patch
sc requested code review of "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
Reviewers: dhruba, tedyu, JIRA
Update metrics numOpenConnections and callQueueLen directly in HBaseServer
This removes the circular dependency of HbaseRpcMetrics and HBaseServer. There
are also two minor changes.
1. Remove unnecessary locking
2. Add metrics for priorityCallQueueLen
It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1509
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3129/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5297.D1509.1.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5297:
------------------------------
Fix Version/s: 0.94.0
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5297) Update metrics numOpenConnections and
callQueueLen directly in HBaseServer
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5297:
-------------------------------
Attachment: HBASE-5297.D1509.2.patch
sc updated the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
Reviewers: dhruba, tedyu, JIRA
Addressed Zhihong's comment in the jira.
Removed getCallQueueLen() and getNumOpenConnections() in RpcServer.java
REVISION DETAIL
https://reviews.facebook.net/D1509
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195437#comment-13195437 ]
Phabricator commented on HBASE-5297:
------------------------------------
tedyu has commented on the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
Haven't figured out why there were extra failed tests reported by Hadoop QA for patch v2.
On my MacBook, the following tests passed (last command looped TestAtomicOperation 4 times):
558 mt -Dtest=TestAtomicOperation
559 mt -Dtest=TestLruBlockCache
561 ~/runtest.sh 4 TestAtomicOperation
REVISION DETAIL
https://reviews.facebook.net/D1509
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195489#comment-13195489 ]
Phabricator commented on HBASE-5297:
------------------------------------
tedyu has accepted the revision "HBASE-5297 [jira] Update metrics numOpenConnections and callQueueLen directly in HBaseServer".
No new failed tests or hanging tests were found by Hadoop QA:
https://builds.apache.org/job/PreCommit-HBASE-Build/863/console
REVISION DETAIL
https://reviews.facebook.net/D1509
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections
and callQueueLen directly in HBaseServer
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195442#comment-13195442 ]
Hadoop QA commented on HBASE-5297:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512289/HBASE-5297.D1509.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -140 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/863//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/863//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/863//console
This message is automatically generated.
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
> Key: HBASE-5297
> URL: https://issues.apache.org/jira/browse/HBASE-5297
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, HBASE-5297.D1509.3.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira