You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/22 09:13:23 UTC
[GitHub] [incubator-nuttx-apps] OctopusHu0105 opened a new pull request #1023: apps/trace: add switch and dump instrumentation
OctopusHu0105 opened a new pull request #1023:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1023
usage:
trace switch switch [+|-]
Configure switch trace filter
trace print [+|-]
Configure dump trace filter
Signed-off-by: zhanghu6 <zh...@xiaomi.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1023: apps/trace: add switch and dump instrumentation
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1023:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1023#discussion_r811910333
##########
File path: system/trace/trace.c
##########
@@ -440,6 +466,54 @@ static int trace_cmd_mode(int index, int argc, FAR char **argv,
return index;
}
+/****************************************************************************
+ * Name: trace_cmd_switch
+ ****************************************************************************/
+
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+static int trace_cmd_switch(int index, int argc, FAR char **argv,
+ int notectlfd)
Review comment:
```suggestion
int notectlfd)
```
##########
File path: system/trace/trace.c
##########
@@ -642,6 +716,54 @@ static int trace_cmd_irq(int index, int argc, FAR char **argv, int notectlfd)
}
#endif
+/****************************************************************************
+ * Name: trace_cmd_print
+ ****************************************************************************/
+
+#ifdef CONFIG_SCHED_INSTRUMENTATION_DUMP
+static int trace_cmd_print(int index, int argc, FAR char **argv,
+ int notectlfd)
Review comment:
```suggestion
int notectlfd)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis merged pull request #1023: apps/trace: add switch and dump instrumentation
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1023:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org