You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Rohit Kalkur <ro...@gmail.com> on 2013/09/13 20:13:21 UTC
Review Request 14131: Adding hasRegionWidgets method to PageResource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14131/
-----------------------------------------------------------
Review request for rave.
Repository: rave
Description
-------
Adding in a hasRegionWidgets() method to the PageResource. This is used to check whether or not to hide/show the "Add widgets to this page" message.
Diffs
-----
/branches/angular/rave-portal-resources/src/main/webapp/static/css/bootstrap/less/mixins.less 1522714
/branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/tabs.html 1522714
/branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesResource.js 1522714
Diff: https://reviews.apache.org/r/14131/diff/
Testing
-------
Thanks,
Rohit Kalkur
Re: Review Request 14131: Adding hasRegionWidgets method to PageResource
Posted by Erin Noe-Payne <er...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14131/#review26089
-----------------------------------------------------------
Ship it!
Code looks good to me.
In terms of process: You should be logging jira tickets when you encounter bugs / new tasks, and then associate the review with those tickets. This ensures that if other people are experience the same issue they can search and see that it is know / has been addressed. I would say go ahead and do that for these two tasks.
- Erin Noe-Payne
On Sept. 13, 2013, 6:13 p.m., Rohit Kalkur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14131/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 6:13 p.m.)
>
>
> Review request for rave.
>
>
> Repository: rave
>
>
> Description
> -------
>
> Adding in a hasRegionWidgets() method to the PageResource. This is used to check whether or not to hide/show the "Add widgets to this page" message.
>
>
> Diffs
> -----
>
> /branches/angular/rave-portal-resources/src/main/webapp/static/css/bootstrap/less/mixins.less 1522714
> /branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/tabs.html 1522714
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesResource.js 1522714
>
> Diff: https://reviews.apache.org/r/14131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohit Kalkur
>
>
Re: Review Request 14131: Adding hasRegionWidgets method to PageResource
Posted by Daniel Gornstein <dg...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14131/#review26351
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Gornstein
On Sept. 13, 2013, 7:25 p.m., Rohit Kalkur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14131/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 7:25 p.m.)
>
>
> Review request for rave.
>
>
> Bugs: RAVE-1058
> https://issues.apache.org/jira/browse/RAVE-1058
>
>
> Repository: rave
>
>
> Description
> -------
>
> Adding in a hasRegionWidgets() method to the PageResource. This is used to check whether or not to hide/show the "Add widgets to this page" message.
>
>
> Diffs
> -----
>
> /branches/angular/rave-portal-resources/src/main/webapp/static/css/bootstrap/less/mixins.less 1522714
> /branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/tabs.html 1522714
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesResource.js 1522714
>
> Diff: https://reviews.apache.org/r/14131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohit Kalkur
>
>
Re: Review Request 14131: Adding hasRegionWidgets method to PageResource
Posted by Rohit Kalkur <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14131/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 7:25 p.m.)
Review request for rave.
Changes
-------
Attaching JIRA bug report reference.
Bugs: RAVE-1058
https://issues.apache.org/jira/browse/RAVE-1058
Repository: rave
Description
-------
Adding in a hasRegionWidgets() method to the PageResource. This is used to check whether or not to hide/show the "Add widgets to this page" message.
Diffs
-----
/branches/angular/rave-portal-resources/src/main/webapp/static/css/bootstrap/less/mixins.less 1522714
/branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/tabs.html 1522714
/branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesResource.js 1522714
Diff: https://reviews.apache.org/r/14131/diff/
Testing
-------
Thanks,
Rohit Kalkur