[GitHub] [druid] maytasm commented on a change in pull request #11426: compaction/status API retains status for datasources that no longer existed causing in-memory used to grow unbounded

[GitBox <gi...@apache.org>]

maytasm commented on a change in pull request #11426:
URL: https://github.com/apache/druid/pull/11426#discussion_r666799253



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java
##########
@@ -213,11 +212,11 @@ public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params)
         }
       } else {
         LOG.info("compactionConfig is empty. Skip.");
-        updateAutoCompactionSnapshotWhenNoCompactTaskScheduled(currentRunAutoCompactionSnapshotBuilders);
+        autoCompactionSnapshotPerDataSource.set(new HashMap<>());

Review comment:
       This will only trigger when you have no compaction config for any datasource




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org