You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by ya...@apache.org on 2021/04/21 01:23:21 UTC
[incubator-doris] branch master updated: not need to deserialize
again (#5644)
This is an automated email from the ASF dual-hosted git repository.
yangzhg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new ab64dbe not need to deserialize again (#5644)
ab64dbe is described below
commit ab64dbe65d006e2519f2e73fd23749c41c6b3fb9
Author: xinghuayu007 <14...@qq.com>
AuthorDate: Wed Apr 21 09:23:12 2021 +0800
not need to deserialize again (#5644)
Co-authored-by: wangxixu <wa...@xiaomi.com>
---
be/src/olap/rowset/rowset_meta_manager.cpp | 1 -
be/src/olap/tablet_meta.cpp | 6 ------
be/src/olap/tablet_meta_manager.cpp | 6 ------
3 files changed, 13 deletions(-)
diff --git a/be/src/olap/rowset/rowset_meta_manager.cpp b/be/src/olap/rowset/rowset_meta_manager.cpp
index 4ed988d..d7ffa96 100644
--- a/be/src/olap/rowset/rowset_meta_manager.cpp
+++ b/be/src/olap/rowset/rowset_meta_manager.cpp
@@ -85,7 +85,6 @@ OLAPStatus RowsetMetaManager::save(OlapMeta* meta, TabletUid tablet_uid, const R
std::string key = ROWSET_PREFIX + tablet_uid.to_string() + "_" + rowset_id.to_string();
std::string value;
bool ret = rowset_meta_pb.SerializeToString(&value);
- ;
if (!ret) {
std::string error_msg = "serialize rowset pb failed. rowset id:" + key;
LOG(WARNING) << error_msg;
diff --git a/be/src/olap/tablet_meta.cpp b/be/src/olap/tablet_meta.cpp
index e691aa2..1acf76c 100644
--- a/be/src/olap/tablet_meta.cpp
+++ b/be/src/olap/tablet_meta.cpp
@@ -304,12 +304,6 @@ OLAPStatus TabletMeta::serialize(string* meta_binary) {
if (!serialize_success) {
LOG(FATAL) << "failed to serialize meta " << full_name();
}
- // deserialize the meta to check the result is correct
- TabletMetaPB de_tablet_meta_pb;
- bool parsed = de_tablet_meta_pb.ParseFromString(*meta_binary);
- if (!parsed) {
- LOG(FATAL) << "deserialize from previous serialize result failed " << full_name();
- }
return OLAP_SUCCESS;
}
diff --git a/be/src/olap/tablet_meta_manager.cpp b/be/src/olap/tablet_meta_manager.cpp
index e6de35e..27775f8 100644
--- a/be/src/olap/tablet_meta_manager.cpp
+++ b/be/src/olap/tablet_meta_manager.cpp
@@ -104,12 +104,6 @@ OLAPStatus TabletMetaManager::save(DataDir* store, TTabletId tablet_id, TSchemaH
VLOG_NOTICE << "save tablet meta to meta store: key = " << key;
OlapMeta* meta = store->get_meta();
- TabletMetaPB de_tablet_meta_pb;
- bool parsed = de_tablet_meta_pb.ParseFromString(meta_binary);
- if (!parsed) {
- LOG(FATAL) << "deserialize from previous serialize result failed";
- }
-
LOG(INFO) << "save tablet meta "
<< ", key:" << key << " meta_size=" << meta_binary.length();
return meta->put(META_COLUMN_FAMILY_INDEX, key, meta_binary);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org