You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/04/19 10:15:37 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #295: remove akka specific algolia and google analytics values
pjfanning opened a new pull request, #295:
URL: https://github.com/apache/incubator-pekko/pull/295
see #245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #295: remove akka specific algolia and google analytics values
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #295:
URL: https://github.com/apache/incubator-pekko/pull/295#discussion_r1171363955
##########
project/Paradox.scala:
##########
@@ -61,10 +61,6 @@ object Paradox {
"pekko.version" -> version.value,
"scalatest.version" -> Dependencies.scalaTestVersion.value,
"sigar_loader.version" -> "1.6.6-rev002",
- "algolia.docsearch.api_key" -> "543bad5ad786495d9ccd445ed34ed082",
- "algolia.docsearch.index_name" -> "akka_io",
- "google.analytics.account" -> "UA-21117439-1",
- "google.analytics.domain.name" -> "akka.io",
Review Comment:
search works anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #295: remove akka specific algolia and google analytics values
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #295:
URL: https://github.com/apache/incubator-pekko/pull/295#discussion_r1171242152
##########
project/Paradox.scala:
##########
@@ -61,10 +61,6 @@ object Paradox {
"pekko.version" -> version.value,
"scalatest.version" -> Dependencies.scalaTestVersion.value,
"sigar_loader.version" -> "1.6.6-rev002",
- "algolia.docsearch.api_key" -> "543bad5ad786495d9ccd445ed34ed082",
- "algolia.docsearch.index_name" -> "akka_io",
- "google.analytics.account" -> "UA-21117439-1",
- "google.analytics.domain.name" -> "akka.io",
Review Comment:
ASF bans the use of Google Analytics for privacy reasons - see https://github.com/apache/incubator-pekko-sbt-paradox/pull/54
I don't know much about Algolia but
* I don't want to use Lightbend's api key
* We will have to jump through hoops to get ASF to approve us getting an Algolia account and since I don't even know what value-add it gives to the Pekko/Akka docs, I'd prefer to remove the settings and we can look at adding Pekko/ASF specific settings if and when it turns out Algolia is needed or super useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #295: remove akka specific algolia and google analytics values
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #295:
URL: https://github.com/apache/incubator-pekko/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #295: remove akka specific algolia and google analytics values
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #295:
URL: https://github.com/apache/incubator-pekko/pull/295#discussion_r1171360957
##########
project/Paradox.scala:
##########
@@ -61,10 +61,6 @@ object Paradox {
"pekko.version" -> version.value,
"scalatest.version" -> Dependencies.scalaTestVersion.value,
"sigar_loader.version" -> "1.6.6-rev002",
- "algolia.docsearch.api_key" -> "543bad5ad786495d9ccd445ed34ed082",
- "algolia.docsearch.index_name" -> "akka_io",
- "google.analytics.account" -> "UA-21117439-1",
- "google.analytics.domain.name" -> "akka.io",
Review Comment:
It adds search ability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #295: remove akka specific algolia and google analytics values
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #295:
URL: https://github.com/apache/incubator-pekko/pull/295#discussion_r1171215498
##########
project/Paradox.scala:
##########
@@ -61,10 +61,6 @@ object Paradox {
"pekko.version" -> version.value,
"scalatest.version" -> Dependencies.scalaTestVersion.value,
"sigar_loader.version" -> "1.6.6-rev002",
- "algolia.docsearch.api_key" -> "543bad5ad786495d9ccd445ed34ed082",
- "algolia.docsearch.index_name" -> "akka_io",
- "google.analytics.account" -> "UA-21117439-1",
- "google.analytics.domain.name" -> "akka.io",
Review Comment:
Any change to update with pekko's
##########
project/Paradox.scala:
##########
@@ -61,10 +61,6 @@ object Paradox {
"pekko.version" -> version.value,
"scalatest.version" -> Dependencies.scalaTestVersion.value,
"sigar_loader.version" -> "1.6.6-rev002",
- "algolia.docsearch.api_key" -> "543bad5ad786495d9ccd445ed34ed082",
- "algolia.docsearch.index_name" -> "akka_io",
- "google.analytics.account" -> "UA-21117439-1",
- "google.analytics.domain.name" -> "akka.io",
Review Comment:
Any chance to update with pekko's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org