You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/03 09:27:15 UTC

[GitHub] [couchdb-nano] glynnbird opened a new pull request #212: improve MangoSelector TypeScript type - fixes issue #211

glynnbird opened a new pull request #212: improve MangoSelector TypeScript type - fixes issue #211
URL: https://github.com/apache/couchdb-nano/pull/212
 
 
   ## Overview
   
   As pointed out in issue #211, a MangoSeletor needs to be able to handle top-level strings so the TypeScript definition needs loosening a little to accept either a MangoOperator or just a string literal.
   
   ## Testing recommendations
   
   ```
   tsc --strict lib/nano.d.ts
   ```
   
   ## GitHub issue number
   
   #211 
   
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-nano] glynnbird merged pull request #212: improve MangoSelector TypeScript type - fixes issue #211

Posted by GitBox <gi...@apache.org>.

glynnbird merged pull request #212: improve MangoSelector TypeScript type - fixes issue #211
URL: https://github.com/apache/couchdb-nano/pull/212
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services