[GitHub] [incubator-superset] khtruong commented on issue #7770: Autocomplete in the table browser in SQL lab is broken - Fix part 2

[GitBox <gi...@apache.org>]

khtruong commented on issue #7770: Autocomplete in the table browser in SQL lab is broken - Fix part 2
URL: https://github.com/apache/incubator-superset/pull/7770#issuecomment-507359107
 
 
   > One problem that @mistercrunch pointed out is that if `value` always contains only the table name, it will not be possible to search over the fully qualified name if no schema is selected multi schema fetch is enabled. However, if we add a property `table` with only the table name, and provide fully qualified names in `value` when no schema is selected (otherwise just table name) similar to how `label` is now populated, searching over both schema and table will be possible.
   > 
   > I think these changes go slightly beyond the original intent of this PR, so I propose we merge this as is, and I can put together a new PR that tackles this stuff I've just proposed (should be fairly quick).
   
   Got it. That would be awesome if you have time. Otherwise, we can file an issue to track it for the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org