[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #371: [YUNIKORN-1076] Robust handling of invalid Task Group annotation

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #371:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/371#discussion_r812474773



##########
File path: pkg/appmgmt/general/general.go
##########
@@ -146,6 +146,8 @@ func (os *Manager) getAppMetadata(pod *v1.Pod) (interfaces.ApplicationMetadata,
 				zap.String("namespace", pod.Namespace),
 				zap.String("name", pod.Name),
 				zap.Error(err))
+			events.GetRecorder().Eventf(pod, nil, v1.EventTypeWarning, "TaskGroupFormatError", "TaskGroupFormatError",
+				"unable to get taskGroups for pod, pod namespace: %s, pod name: %s, reason: %s", appID, pod.Namespace, pod.Name, err.Error())

Review comment:
       I think we have a discrepancy here between the number of args passed in and the formatting directives in the string:
   ```
   unable to get taskGroups for pod, pod namespace: <appID>, pod name: <pod.Namespace>, reason: pod.Name
   ```
   I think there is a `%s` missing between "pod" and the first comma




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org