You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Antoine Pitrou <an...@python.org> on 2019/11/04 17:09:09 UTC
[CI] Disable coverage on Travis-CI?
Hello,
Code coverage computation on Travis-CI builds probably takes a
non-trivial amount of time and it's not obvious anyone is using the
results concretely. Should we disable it?
(note we may also disable it selectively on C++, Python, or Rust,
depending on the answers)
Regards
Antoine.
Re: [CI] Disable coverage on Travis-CI?
Posted by Wes McKinney <we...@gmail.com>.
I just asked INFRA to turn off the Codecov PR reports, which I don't
think anyone looks at anyway
https://issues.apache.org/jira/browse/INFRA-19390
On Mon, Nov 4, 2019 at 7:12 PM Krisztián Szűcs
<sz...@gmail.com> wrote:
>
> I'm heavily working on it to get a mergeable state. There are left 2-3
> failing builds, but I still need to ensure that the crossbow nightly builds
> are still working.
>
> On Mon, Nov 4, 2019 at 9:07 PM Wes McKinney <we...@gmail.com> wrote:
> >
> > FWIW I think that coverage was axed in the GitHub Actions work that
> > Krisztian has been doing, which also nixes Travis CI altogether. Not
> > sure what the timeline is for merging that however
> >
> > On Mon, Nov 4, 2019 at 11:29 AM Neal Richardson
> > <ne...@gmail.com> wrote:
> > >
> > > A nightly coverage build would also have the benefit of actually being
> > > useful. Because we rarely run all of the coverage jobs on a single
> > > pull request, the report of the change in coverage from a diff is
> > > worthless.
> > >
> > > Neal
> > >
> > > On Mon, Nov 4, 2019 at 9:16 AM Wes McKinney <we...@gmail.com> wrote:
> > > >
> > > > I'm okay with disabling it. It will speed up many of our CI builds.
> > > >
> > > > If we care about code coverage, I would suggest running nightly
> > > > coverage builds rather than every commit
> > > >
> > > > On Mon, Nov 4, 2019 at 11:09 AM Antoine Pitrou <an...@python.org> wrote:
> > > > >
> > > > >
> > > > > Hello,
> > > > >
> > > > > Code coverage computation on Travis-CI builds probably takes a
> > > > > non-trivial amount of time and it's not obvious anyone is using the
> > > > > results concretely. Should we disable it?
> > > > >
> > > > > (note we may also disable it selectively on C++, Python, or Rust,
> > > > > depending on the answers)
> > > > >
> > > > > Regards
> > > > >
> > > > > Antoine.
Re: [CI] Disable coverage on Travis-CI?
Posted by Krisztián Szűcs <sz...@gmail.com>.
I'm heavily working on it to get a mergeable state. There are left 2-3
failing builds, but I still need to ensure that the crossbow nightly builds
are still working.
On Mon, Nov 4, 2019 at 9:07 PM Wes McKinney <we...@gmail.com> wrote:
>
> FWIW I think that coverage was axed in the GitHub Actions work that
> Krisztian has been doing, which also nixes Travis CI altogether. Not
> sure what the timeline is for merging that however
>
> On Mon, Nov 4, 2019 at 11:29 AM Neal Richardson
> <ne...@gmail.com> wrote:
> >
> > A nightly coverage build would also have the benefit of actually being
> > useful. Because we rarely run all of the coverage jobs on a single
> > pull request, the report of the change in coverage from a diff is
> > worthless.
> >
> > Neal
> >
> > On Mon, Nov 4, 2019 at 9:16 AM Wes McKinney <we...@gmail.com> wrote:
> > >
> > > I'm okay with disabling it. It will speed up many of our CI builds.
> > >
> > > If we care about code coverage, I would suggest running nightly
> > > coverage builds rather than every commit
> > >
> > > On Mon, Nov 4, 2019 at 11:09 AM Antoine Pitrou <an...@python.org> wrote:
> > > >
> > > >
> > > > Hello,
> > > >
> > > > Code coverage computation on Travis-CI builds probably takes a
> > > > non-trivial amount of time and it's not obvious anyone is using the
> > > > results concretely. Should we disable it?
> > > >
> > > > (note we may also disable it selectively on C++, Python, or Rust,
> > > > depending on the answers)
> > > >
> > > > Regards
> > > >
> > > > Antoine.
Re: [CI] Disable coverage on Travis-CI?
Posted by Wes McKinney <we...@gmail.com>.
FWIW I think that coverage was axed in the GitHub Actions work that
Krisztian has been doing, which also nixes Travis CI altogether. Not
sure what the timeline is for merging that however
On Mon, Nov 4, 2019 at 11:29 AM Neal Richardson
<ne...@gmail.com> wrote:
>
> A nightly coverage build would also have the benefit of actually being
> useful. Because we rarely run all of the coverage jobs on a single
> pull request, the report of the change in coverage from a diff is
> worthless.
>
> Neal
>
> On Mon, Nov 4, 2019 at 9:16 AM Wes McKinney <we...@gmail.com> wrote:
> >
> > I'm okay with disabling it. It will speed up many of our CI builds.
> >
> > If we care about code coverage, I would suggest running nightly
> > coverage builds rather than every commit
> >
> > On Mon, Nov 4, 2019 at 11:09 AM Antoine Pitrou <an...@python.org> wrote:
> > >
> > >
> > > Hello,
> > >
> > > Code coverage computation on Travis-CI builds probably takes a
> > > non-trivial amount of time and it's not obvious anyone is using the
> > > results concretely. Should we disable it?
> > >
> > > (note we may also disable it selectively on C++, Python, or Rust,
> > > depending on the answers)
> > >
> > > Regards
> > >
> > > Antoine.
Re: [CI] Disable coverage on Travis-CI?
Posted by Neal Richardson <ne...@gmail.com>.
A nightly coverage build would also have the benefit of actually being
useful. Because we rarely run all of the coverage jobs on a single
pull request, the report of the change in coverage from a diff is
worthless.
Neal
On Mon, Nov 4, 2019 at 9:16 AM Wes McKinney <we...@gmail.com> wrote:
>
> I'm okay with disabling it. It will speed up many of our CI builds.
>
> If we care about code coverage, I would suggest running nightly
> coverage builds rather than every commit
>
> On Mon, Nov 4, 2019 at 11:09 AM Antoine Pitrou <an...@python.org> wrote:
> >
> >
> > Hello,
> >
> > Code coverage computation on Travis-CI builds probably takes a
> > non-trivial amount of time and it's not obvious anyone is using the
> > results concretely. Should we disable it?
> >
> > (note we may also disable it selectively on C++, Python, or Rust,
> > depending on the answers)
> >
> > Regards
> >
> > Antoine.
Re: [CI] Disable coverage on Travis-CI?
Posted by Wes McKinney <we...@gmail.com>.
I'm okay with disabling it. It will speed up many of our CI builds.
If we care about code coverage, I would suggest running nightly
coverage builds rather than every commit
On Mon, Nov 4, 2019 at 11:09 AM Antoine Pitrou <an...@python.org> wrote:
>
>
> Hello,
>
> Code coverage computation on Travis-CI builds probably takes a
> non-trivial amount of time and it's not obvious anyone is using the
> results concretely. Should we disable it?
>
> (note we may also disable it selectively on C++, Python, or Rust,
> depending on the answers)
>
> Regards
>
> Antoine.