You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/05 22:24:37 UTC
[GitHub] [druid] gianm opened a new pull request #11886: RowBasedSegment: Use Sequence instead of Iterable.
gianm opened a new pull request #11886:
URL: https://github.com/apache/druid/pull/11886
The main reason this is good is that Sequences can include baggage that
must be closed after iteration is finished. This enables creating
RowBasedSegments on top of closeable sequences of rows.
To preserve the optimization that allows reversing a List without
copying it, this patch also makes SimpleSequence its own class and allows
extracting the Iterable that was used to create it.
Nothing actually uses this capability yet, but in future work I'd like to explore
building RowBasedSegments on top of more kinds of things, some of which
may need to have resource cleanup associated with them. So this patch
enables that without bothering existing usages too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11886: RowBasedSegment: Use Sequence instead of Iterable.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11886:
URL: https://github.com/apache/druid/pull/11886#issuecomment-963499828
In this patch, I added an extra state validation to `RowWalker.advance` making sure that `!isDone()`. This caused a test failure in CalciteQueryTest.testFilterAndGroupByLookupUsingJoinOperatorBackwards, revealing a bug in HashJoinEngine. I'll fix that in a separate PR, which will have to go in before this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11886: RowBasedSegment: Use Sequence instead of Iterable.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11886:
URL: https://github.com/apache/druid/pull/11886#issuecomment-963511886
> In this patch, I added an extra state validation to `RowWalker.advance` making sure that `!isDone()`. This caused a test failure in CalciteQueryTest.testFilterAndGroupByLookupUsingJoinOperatorBackwards, revealing a bug in HashJoinEngine. I'll fix that in a separate PR, which will have to go in before this one.
The bug fix: https://github.com/apache/druid/pull/11890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #11886: RowBasedSegment: Use Sequence instead of Iterable.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #11886:
URL: https://github.com/apache/druid/pull/11886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org