You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "sunil9977 (via GitHub)" <gi...@apache.org> on 2025/04/30 03:58:54 UTC
[PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
sunil9977 opened a new pull request, #4130:
URL: https://github.com/apache/cassandra/pull/4130
Cassandra-20191
Optimizes StorageAttachedIndexSearcher.ResultRetriever to avoid scanning all rows in large partitions by leveraging partition and clustering filters for direct skips.
patch by Sunil Ramchandra Pawar; reviewed by Caleb Rackliffe for CASSANDRA-20191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "sunil9977 (via GitHub)" <gi...@apache.org>.
sunil9977 commented on code in PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#discussion_r2077212022
##########
test/unit/org/apache/cassandra/index/sai/cql/IntraPartitionSkippingTest.java:
##########
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.index.sai.cql;
+
+import org.junit.Test;
+
+import org.apache.cassandra.index.sai.SAITester;
+
+/**
+ * Tests for verifying intra-partition and partition-level skipping optimizations
+ * introduced in CASSANDRA-20191 for SAI.
+ * <p>
+ * These tests validate that Cassandra can efficiently skip over rows
+ * within a partition using clustering filters (name and slice), paging, reversed order,
+ * and sparse matches.
+ * <p>
+ * Each test documents a scenario where skipping logic is expected to apply along with few where it doesn't skip.
+ */
+public class IntraPartitionSkippingTest extends SAITester
+{
+ @Test
+ public void testNameFilterExactMatch()
+ {
+ createTable("CREATE TABLE %S (pk int, ck int, val text, PRIMARY KEY (pk, ck))");
+ createIndex("CREATE CUSTOM INDEX ON %s(val) USING 'sai'");
+
+ for (int ck = 0; ck < 10; ck++)
+ {
+ execute("INSERT INTO %s (pk, ck, val) VALUES (?, ?, ?)", 1, ck, "val" + ck);
+ }
+ flush();
Review Comment:
Sure, replaced with beforeAndAfterFlush.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#discussion_r2076428279
##########
test/unit/org/apache/cassandra/index/sai/cql/IntraPartitionSkippingTest.java:
##########
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.index.sai.cql;
+
+import org.junit.Test;
+
+import org.apache.cassandra.index.sai.SAITester;
+
+/**
+ * Tests for verifying intra-partition and partition-level skipping optimizations
+ * introduced in CASSANDRA-20191 for SAI.
+ * <p>
+ * These tests validate that Cassandra can efficiently skip over rows
+ * within a partition using clustering filters (name and slice), paging, reversed order,
+ * and sparse matches.
+ * <p>
+ * Each test documents a scenario where skipping logic is expected to apply along with few where it doesn't skip.
+ */
+public class IntraPartitionSkippingTest extends SAITester
+{
+ @Test
+ public void testNameFilterExactMatch()
+ {
+ createTable("CREATE TABLE %S (pk int, ck int, val text, PRIMARY KEY (pk, ck))");
+ createIndex("CREATE CUSTOM INDEX ON %s(val) USING 'sai'");
Review Comment:
nit:
```suggestion
createIndex("CREATE INDEX ON %s(val) USING 'sai'");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#issuecomment-2864154517
Committed as https://github.com/apache/cassandra/commit/ab1ce5938d89a08ebdfbd8ccca48498066b7cbda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "sunil9977 (via GitHub)" <gi...@apache.org>.
sunil9977 commented on PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#issuecomment-2850793795
Thanks, Caleb. I've incorporated the adjustments you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#discussion_r2076430471
##########
test/unit/org/apache/cassandra/index/sai/cql/IntraPartitionSkippingTest.java:
##########
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.index.sai.cql;
+
+import org.junit.Test;
+
+import org.apache.cassandra.index.sai.SAITester;
+
+/**
+ * Tests for verifying intra-partition and partition-level skipping optimizations
+ * introduced in CASSANDRA-20191 for SAI.
+ * <p>
+ * These tests validate that Cassandra can efficiently skip over rows
+ * within a partition using clustering filters (name and slice), paging, reversed order,
+ * and sparse matches.
+ * <p>
+ * Each test documents a scenario where skipping logic is expected to apply along with few where it doesn't skip.
+ */
+public class IntraPartitionSkippingTest extends SAITester
+{
+ @Test
+ public void testNameFilterExactMatch()
+ {
+ createTable("CREATE TABLE %S (pk int, ck int, val text, PRIMARY KEY (pk, ck))");
+ createIndex("CREATE CUSTOM INDEX ON %s(val) USING 'sai'");
+
+ for (int ck = 0; ck < 10; ck++)
+ {
+ execute("INSERT INTO %s (pk, ck, val) VALUES (?, ?, ?)", 1, ck, "val" + ck);
+ }
+ flush();
+ assertRowCount(execute("SELECT * FROM %s WHERE pk = 1 AND ck = 5 AND val = 'val5' ALLOW FILTERING"), 1);
Review Comment:
If it's only a few rows, let's use `assertRowsNet` or `assertRows` to check the full row...possibly paranoid, but it doesn't make things too ugly.
##########
test/unit/org/apache/cassandra/index/sai/cql/IntraPartitionSkippingTest.java:
##########
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.index.sai.cql;
+
+import org.junit.Test;
+
+import org.apache.cassandra.index.sai.SAITester;
+
+/**
+ * Tests for verifying intra-partition and partition-level skipping optimizations
+ * introduced in CASSANDRA-20191 for SAI.
+ * <p>
+ * These tests validate that Cassandra can efficiently skip over rows
+ * within a partition using clustering filters (name and slice), paging, reversed order,
+ * and sparse matches.
+ * <p>
+ * Each test documents a scenario where skipping logic is expected to apply along with few where it doesn't skip.
+ */
+public class IntraPartitionSkippingTest extends SAITester
+{
+ @Test
+ public void testNameFilterExactMatch()
+ {
+ createTable("CREATE TABLE %S (pk int, ck int, val text, PRIMARY KEY (pk, ck))");
+ createIndex("CREATE CUSTOM INDEX ON %s(val) USING 'sai'");
+
+ for (int ck = 0; ck < 10; ck++)
+ {
+ execute("INSERT INTO %s (pk, ck, val) VALUES (?, ?, ?)", 1, ck, "val" + ck);
+ }
+ flush();
+ assertRowCount(execute("SELECT * FROM %s WHERE pk = 1 AND ck = 5 AND val = 'val5' ALLOW FILTERING"), 1);
Review Comment:
If it's only a few rows, let's use `assertRowsNet` or `assertRows` to check the full response...possibly paranoid, but it doesn't make things too ugly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#discussion_r2076428015
##########
test/unit/org/apache/cassandra/index/sai/cql/AllowFilteringTest.java:
##########
@@ -423,4 +424,127 @@ public void testAllowFilteringDuringIndexBuild() throws Throwable
execute("SELECT * FROM %s WHERE v=0");
execute("SELECT * FROM %s WHERE v=0 ALLOW FILTERING");
}
+
+ @Test
+ public void testNextKeyPerfClusteringIndexSliceFilter()
Review Comment:
Let's move all three of these to `IntraPartitionSkippingTest` and then throw `@Ignore` on the perf tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz closed pull request #4130: CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions
URL: https://github.com/apache/cassandra/pull/4130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#issuecomment-2859275756
Latest changes LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#issuecomment-2848084311
Just pushed some adjustments here: https://github.com/maedhroz/cassandra/commits/CASSANDRA-20191-initial-skip/
We can talk more about them when you get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20191 - Optimize initial skipping logic for SAI queries on large partitions [cassandra]
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #4130:
URL: https://github.com/apache/cassandra/pull/4130#discussion_r2076429853
##########
test/unit/org/apache/cassandra/index/sai/cql/IntraPartitionSkippingTest.java:
##########
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.index.sai.cql;
+
+import org.junit.Test;
+
+import org.apache.cassandra.index.sai.SAITester;
+
+/**
+ * Tests for verifying intra-partition and partition-level skipping optimizations
+ * introduced in CASSANDRA-20191 for SAI.
+ * <p>
+ * These tests validate that Cassandra can efficiently skip over rows
+ * within a partition using clustering filters (name and slice), paging, reversed order,
+ * and sparse matches.
+ * <p>
+ * Each test documents a scenario where skipping logic is expected to apply along with few where it doesn't skip.
+ */
+public class IntraPartitionSkippingTest extends SAITester
+{
+ @Test
+ public void testNameFilterExactMatch()
+ {
+ createTable("CREATE TABLE %S (pk int, ck int, val text, PRIMARY KEY (pk, ck))");
+ createIndex("CREATE CUSTOM INDEX ON %s(val) USING 'sai'");
+
+ for (int ck = 0; ck < 10; ck++)
+ {
+ execute("INSERT INTO %s (pk, ck, val) VALUES (?, ?, ?)", 1, ck, "val" + ck);
+ }
+ flush();
Review Comment:
We probably want to use `beforeAndAfterFlush(Runnable)` to test the skipping across both Memtable index postings and on-disk postings. See `StaticColumnIndexTest` for usage examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org