[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4430: [ODBC SCAN NODE] 3/4 Add ODBC_TABLE and ODBC_SCAN NODE in FE.

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #4430:
URL: https://github.com/apache/incubator-doris/pull/4430#discussion_r476402115



##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/OdbcTable.java
##########
@@ -0,0 +1,296 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.catalog;
+
+import com.google.common.collect.Maps;
+import org.apache.doris.common.DdlException;
+import org.apache.doris.common.io.Text;
+import org.apache.doris.thrift.TOdbcTable;
+import org.apache.doris.thrift.TTableDescriptor;
+import org.apache.doris.thrift.TTableType;
+import org.apache.doris.thrift.TOdbcTableType;
+
+import com.google.common.base.Strings;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.zip.Adler32;
+
+public class OdbcTable extends Table {
+    private static final Logger LOG = LogManager.getLogger(OlapTable.class);
+
+    private static final String ODBC_HOST = "host";
+    private static final String ODBC_PORT = "port";
+    private static final String ODBC_USER = "user";
+    private static final String ODBC_PASSWORD = "password";
+    private static final String ODBC_DATABASE = "database";
+    private static final String ODBC_TABLE = "table";
+    private static final String ODBC_DRIVER = "driver";
+    private static final String ODBC_TYPE = "type";
+
+    private static Map<String, TOdbcTableType> TABLE_TYPE_MAP;
+    static {
+        Map<String, TOdbcTableType> tempMap = new HashMap<>();
+        tempMap.put("oracle", TOdbcTableType.ORACLE);
+        // we will support mysql driver in the future after we slove the core problem of
+        // driver and static library
+        //tempMap.put("mysql", TOdbcTableType.MYSQL);
+        TABLE_TYPE_MAP = Collections.unmodifiableMap(tempMap);
+    }
+
+    private String host;
+    private String port;
+    private String userName;
+    private String passwd;
+    private String odbcDatabaseName;
+    private String odbcTableName;
+    private String driver;
+    private String odbcTableTypeName;
+
+    public OdbcTable() {
+        super(TableType.ODBC);
+    }
+
+    public OdbcTable(long id, String name, List<Column> schema, Map<String, String> properties)
+            throws DdlException {
+        super(id, name, TableType.ODBC, schema);
+        validate(properties);
+    }
+
+    private void validate(Map<String, String> properties) throws DdlException {
+        if (properties == null) {
+            throw new DdlException("Please set properties of odbc table, "
+                    + "they are: host, port, user, password, database and table");
+        }
+
+        // Set up
+        host = properties.get(ODBC_HOST);
+        if (Strings.isNullOrEmpty(host)) {
+            throw new DdlException("Host of Odbc table is null. "
+                    + "Please add properties('host'='xxx.xxx.xxx.xxx') when create table");
+        }
+
+        port = properties.get(ODBC_PORT);
+        if (Strings.isNullOrEmpty(port)) {
+            // Maybe null pointer or number convert
+            throw new DdlException("Port of Odbc table is null. "
+                    + "Please add properties('port'='3306') when create table");
+        } else {
+            try {
+                Integer.valueOf(port);
+            } catch (Exception e) {
+                throw new DdlException("Port of Odbc table must be a number."
+                        + "Please add properties('port'='3306') when create table");
+
+            }
+        }
+
+        userName = properties.get(ODBC_USER);
+        if (Strings.isNullOrEmpty(userName)) {
+            throw new DdlException("User of Odbc table is null. "
+                    + "Please add properties('user'='root') when create table");
+        }
+
+        passwd = properties.get(ODBC_PASSWORD);
+        if (passwd == null) {
+            throw new DdlException("Password of Odbc table is null. "
+                    + "Please add properties('password'='xxxx') when create table");
+        }
+
+        odbcDatabaseName = properties.get(ODBC_DATABASE);
+        if (Strings.isNullOrEmpty(odbcDatabaseName)) {
+            throw new DdlException("Database of Odbc table is null. "
+                    + "Please add properties('database'='xxxx') when create table");
+        }
+
+        odbcTableName = properties.get(ODBC_TABLE);
+        if (Strings.isNullOrEmpty(odbcTableName)) {
+            throw new DdlException("Database of Odbc table is null. "
+                    + "Please add properties('table'='xxxx') when create table");
+        }
+
+        driver = properties.get(ODBC_DRIVER);
+        if (Strings.isNullOrEmpty(driver)) {
+            throw new DdlException("Driver of Odbc table is null. "
+                    + "Please add properties('diver'='xxxx') when create table");
+        }
+
+        String tableType = properties.get(ODBC_TYPE);
+        if (Strings.isNullOrEmpty(tableType)) {
+            throw new DdlException("Type of Odbc table is null. "
+                    + "Please add properties('type'='xxxx') when create table");
+        } else {
+            odbcTableTypeName = tableType.toLowerCase();
+            if (!TABLE_TYPE_MAP.containsKey(odbcTableTypeName)) {
+                throw new DdlException("Invaild Odbc table type:" + tableType
+                + " Now Odbc table type only support:" + supportTableType());
+            }
+        }
+    }
+
+    public String getHost() {
+        return host;
+    }
+
+    public String getPort() {
+        return port;
+    }
+
+    public String getUserName() {
+        return userName;
+    }
+
+    public String getPasswd() {
+        return passwd;
+    }
+
+    public String getOdbcDatabaseName() {
+        return odbcDatabaseName;
+    }
+
+    public String getOdbcTableName() {
+        return odbcTableName;
+    }
+
+    public String getOdbcDriver() {
+        return driver;
+    }
+
+    public String getOdbcTableTypeName() {
+        return odbcTableTypeName;
+    }
+
+    public TOdbcTableType getOdbcTableType() {
+        return TABLE_TYPE_MAP.get(odbcTableTypeName);
+    }
+
+    public TTableDescriptor toThrift() {
+        TOdbcTable tOdbcTable =
+                new TOdbcTable();
+
+        tOdbcTable.host = host;
+        tOdbcTable.port = port;
+        tOdbcTable.user = userName;
+        tOdbcTable.passwd = passwd;
+        tOdbcTable.db = odbcDatabaseName;
+        tOdbcTable.table = odbcTableName;
+        tOdbcTable.driver = driver;
+        tOdbcTable.type = getOdbcTableType();
+
+        TTableDescriptor tTableDescriptor = new TTableDescriptor(getId(), TTableType.ODBC_TABLE,
+                fullSchema.size(), 0, getName(), "");
+        tTableDescriptor.setOdbcTable(tOdbcTable);
+        return tTableDescriptor;
+    }
+
+    @Override
+    public int getSignature(int signatureVersion) {
+        Adler32 adler32 = new Adler32();
+        adler32.update(signatureVersion);
+        String charsetName = "UTF-8";
+
+        try {
+            // name
+            adler32.update(name.getBytes(charsetName));
+            // type
+            adler32.update(type.name().getBytes(charsetName));
+            // host
+            adler32.update(host.getBytes(charsetName));
+            // port
+            adler32.update(port.getBytes(charsetName));
+            // username
+            adler32.update(userName.getBytes(charsetName));
+            // passwd
+            adler32.update(passwd.getBytes(charsetName));
+            // odbc db
+            adler32.update(odbcDatabaseName.getBytes(charsetName));
+            // odbc table
+            adler32.update(odbcTableName.getBytes(charsetName));
+            // odbc driver
+            adler32.update(driver.getBytes(charsetName));
+            // odbc type
+            adler32.update(odbcTableTypeName.getBytes(charsetName));
+        } catch (UnsupportedEncodingException e) {
+            LOG.error("encoding error", e);
+            return -1;
+        }
+
+        return Math.abs((int) adler32.getValue());
+    }
+
+    @Override
+    public void write(DataOutput out) throws IOException {
+        super.write(out);
+
+        Map<String, String> serializeMap = Maps.newHashMap();

Review comment:
       Would better Serde by json




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org