You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/04/04 15:45:06 UTC

[Issue 124599] New: Wndows 4.1.0 installer does not recognize former versions correctly

https://issues.apache.org/ooo/show_bug.cgi?id=124599

          Issue ID: 124599
        Issue Type: DEFECT
           Summary: Wndows 4.1.0 installer does not recognize former
                    versions correctly
           Product: Installation
           Version: 4.1.0-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: orw@apache.org
             Flags: 4.1.0_release_blocker?

The current available Windows 4.1.0 installation packages does not recognize
former installed versions correctly:
- AOO 4.0.1 exists on the system
--> Shortcut in Desktop, StartMenu group and registry entries are still
available after the install.
- AOO 3.4.1 exists on the system
--> Installer doe snot offer option to keep or to delete it
---> AOO 3.4.1 installation, Shortcut in Desktop, StartMenu group and registry
entries are still available after the install.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|4.1.0_release_blocker?      |4.1.0_release_blocker+

--- Comment #11 from jsc@apache.org ---
grant showstopper flag, withdrawn by mistake

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #2 from Andre <aw...@googlemail.com> ---
Created attachment 83085
  --> https://issues.apache.org/ooo/attachment.cgi?id=83085&action=edit
Use hard coded ProductCode as temporary workaround.

This is my current idea of a patch.  Ugly and dirty.  If it turns out to work
then we need a clean replacement soon.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hdu@apache.org

--- Comment #6 from hdu@apache.org <hd...@apache.org> ---
+1 to integrate the change in the AOO410 branch

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
              Flags|4.1.0_release_blocker+      |4.1.0_release_blocker?

--- Comment #10 from Andre <aw...@googlemail.com> ---
Temporary fix exists in branch AOO410.

-- 
You are receiving this mail because:
You are watching all issue changes.

4.1.0_release_blocker requested: [Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
Andre <aw...@googlemail.com> has asked  for 4.1.0_release_blocker:
Issue 124599: Windows 4.1.0 installer does not recognize former versions
correctly
https://issues.apache.org/ooo/show_bug.cgi?id=124599


------- Additional Comments from Andre <aw...@googlemail.com>
Temporary fix exists in branch AOO410.

4.1.0_release_blocker granted: [Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
jsc@apache.org has granted Andre <aw...@googlemail.com>'s request for
4.1.0_release_blocker:
Issue 124599: Windows 4.1.0 installer does not recognize former versions
correctly
https://issues.apache.org/ooo/show_bug.cgi?id=124599


------- Additional Comments from jsc@apache.org
grant showstopper flag, withdrawn by mistake

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83085|                            |review?
              Flags|                            |

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rainerbielefeld_ooo_qa@biel
                   |                            |efeldundbuss.de
            Summary|Wndows 4.1.0 installer does |Windows 4.1.0 installer
                   |not recognize former        |does not recognize former
                   |versions correctly          |versions correctly

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #12 from jsc@apache.org ---
verified on Windows 7 with AOO 4.1.0 RC2, 
I have installed the new 4.1.0 RC2 en-US Version over an existing AOO 4.0.1
version en-US. Desktop icon and menu item are replaced

AOO410m16(Build:9762)  -  Rev. 1585426
2014-04-07 10:29:13 (Mon, 07 Apr 2014)

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"af" committed SVN revision 1584753 into branches/AOO410:
124599: Temporary fix to force the use of the previously used product code.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Edwin Sharp <el...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |elish@apache.org
           Hardware|All                         |PC
                 OS|All                         |Windows, all

-- 
You are receiving this mail because:
You are watching all issue changes.

4.1.0_release_blocker requested: [Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has asked  for 4.1.0_release_blocker:
Issue 124599: Wndows 4.1.0 installer does not recognize former versions
correctly
https://issues.apache.org/ooo/show_bug.cgi?id=124599


------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
The current available Windows 4.1.0 installation packages does not recognize
former installed versions correctly:
- AOO 4.0.1 exists on the system
--> Shortcut in Desktop, StartMenu group and registry entries are still
available after the install.
- AOO 3.4.1 exists on the system
--> Installer doe snot offer option to keep or to delete it
---> AOO 3.4.1 installation, Shortcut in Desktop, StartMenu group and registry
entries are still available after the install.

4.1.0_release_blocker granted: [Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
jsc@apache.org has granted Oliver-Rainer Wittmann <or...@apache.org>'s request
for 4.1.0_release_blocker:
Issue 124599: Windows 4.1.0 installer does not recognize former versions
correctly
https://issues.apache.org/ooo/show_bug.cgi?id=124599


------- Additional Comments from jsc@apache.org
grant showstopper flag

review requested: [Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly : [Attachment 83085] Use hard coded ProductCode as temporary workaround.

Posted by bu...@apache.org.
Andre <aw...@googlemail.com> has asked  for review:
Issue 124599: Wndows 4.1.0 installer does not recognize former versions
correctly
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Attachment 83085: Use hard coded ProductCode as temporary workaround.
https://issues.apache.org/ooo/attachment.cgi?id=83085&action=edit

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Pedro <pe...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedlino@gmail.com

--- Comment #8 from Pedro <pe...@gmail.com> ---
(In reply to Andre from comment #1)
> The root cause for the problem is that the value of UpgradeCode property in
> the MSI is not the same as that of the previous version.  Looks like my
> changes for the patch support removed the code that enforces this.

The update patch does update the Add/Remove list correctly so it's doing
something better than the full installer. However it does not set the AOO icon
as the folder icon for the 4.1.0 group (while the full installer does)

Both ways of updating fail to remove the previous desktop icon and the previous
startup group. BTW this problem also applies when updating from 4.0.0 to 4.1.0

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #3 from Andre <aw...@googlemail.com> ---
- The upgrade code 7C35B9AB-2CE3-4C18-BE7C-5B97EA089EB3 was previously read
from instsetoo_native/inc_openoffice/windows/msi_templates/codes.txt.  Probably
the only information that is still extracted from that file.

- The critical point that causes the problem seems not to be the actual
UpgradeCode property in the PropertyTable but some entries in the Upgrade
table.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #5 from Oliver-Rainer Wittmann <or...@apache.org> ---
+1 for the solution

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #13 from Oliver-Rainer Wittmann <or...@apache.org> ---
I have installed AOO 4.1.0 RC2 on a Windows 7 Home Premium VM system with
certain installation of former OpenOffice versions:
- having AOO 3.4.1 installed
- having AOO 4.0.1 installed
- having AOO 3.4.1 and AOO 4.0.1 installed
- no former OpenOffice versions

All installations went well. All artifacts (known by me) from former OpenOffice
versions have been removed.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.0

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awf.aoo@googlemail.com,
                   |                            |jsc@apache.org,
                   |                            |orw@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 124599] Windows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|4.1.0_release_blocker?      |4.1.0_release_blocker+

--- Comment #9 from jsc@apache.org ---
grant showstopper flag

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #4 from Andre <aw...@googlemail.com> ---
Requesting review.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

--- Comment #1 from Andre <aw...@googlemail.com> ---
The root cause for the problem is that the value of UpgradeCode property in the
MSI is not the same as that of the previous version.  Looks like my changes for
the patch support removed the code that enforces this.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124599] Wndows 4.1.0 installer does not recognize former versions correctly

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124599

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|issues@openoffice.apache.or |awf.aoo@googlemail.com
                   |g                           |

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.