[GitHub] [superset] michael-s-molina commented on pull request #15506: fix(native-filters): Fix native filters config modal

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #15506:
URL: https://github.com/apache/superset/pull/15506#issuecomment-874661997


   The removal of "Value is required" was not a regression. It was a design decision to eliminate the unnecessary spacing among filters. That's why we added the asterisk. This PR reintroduced the text and the spacing.
   
   <img width="281" alt="Screen Shot 2021-07-06 at 7 51 51 AM" src="https://user-images.githubusercontent.com/70410625/124588423-29243500-de2f-11eb-9b34-d2286b3523bf.png">
   
   @simcha90 Can you please roll back to the previous behavior?
   
   @villebro @junlincc @amitmiran137 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org