You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/11 12:56:06 UTC

[GitHub] [flink] fapaul commented on a change in pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)

fapaul commented on a change in pull request #18325:
URL: https://github.com/apache/flink/pull/18325#discussion_r782118007



##########
File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/LogicalScopeProvider.java
##########
@@ -17,13 +17,16 @@
 
 package org.apache.flink.metrics;
 
+import org.apache.flink.annotation.Public;
+
 /**
  * Extension for metric groups that support logical scopes.
  *
  * <p>ATTENTION: This interface is *not* meant for the long-term; it merely removes the need for
  * reporters to depend on flink-runtime in order to access the logical scope. Once the logical scope
  * is properly exposed this interface *will* be removed.
  */
+@Public

Review comment:
       @zentol can you confirm this annotation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org