You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/16 03:34:48 UTC
Review Request 35486: Upgrades Placed Into ABORTED Status Show As
COMPLETED
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35486/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-11939
https://issues.apache.org/jira/browse/AMBARI-11939
Repository: ambari
Description
-------
When placing a stack upgrade request into the ABORTED state, Ambari calculates the stages and overall request as COMPLETED even though the tasks are actually ABORTED.
This prevents that request from being placed back into the PENDING state.
{code}
- Now this upgrade can be aborted:
{code:title=PUT api/v1/clusters/<cluster>/upgrades/21}
{
"Upgrade": {
"request_status": "ABORTED"
}
}
{code}
- At this point, experimental mode can be enabled to work with Ambari. When finalize is ready, the same upgrade/request can be placed back into a {{PENDING}} status:
{code:title=PUT api/v1/clusters/<cluster>/upgrades/21}
{
"Upgrade": {
"request_status": "PENDING"
}
}
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 34fed41
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 79674cb
Diff: https://reviews.apache.org/r/35486/diff/
Testing
-------
mvn clean test
Successfully put a HOLDING upgrade into ABORTED and then resumed it with a PENDING request.
Thanks,
Jonathan Hurley
Re: Review Request 35486: Upgrades Placed Into ABORTED Status Show As
COMPLETED
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35486/#review88021
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 16, 2015, 1:34 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35486/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 1:34 a.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11939
> https://issues.apache.org/jira/browse/AMBARI-11939
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When placing a stack upgrade request into the ABORTED state, Ambari calculates the stages and overall request as COMPLETED even though the tasks are actually ABORTED.
>
> This prevents that request from being placed back into the PENDING state.
>
> {code}
>
> - Now this upgrade can be aborted:
> {code:title=PUT api/v1/clusters/<cluster>/upgrades/21}
> {
> "Upgrade": {
> "request_status": "ABORTED"
> }
> }
> {code}
>
> - At this point, experimental mode can be enabled to work with Ambari. When finalize is ready, the same upgrade/request can be placed back into a {{PENDING}} status:
> {code:title=PUT api/v1/clusters/<cluster>/upgrades/21}
> {
> "Upgrade": {
> "request_status": "PENDING"
> }
> }
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 34fed41
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 79674cb
>
> Diff: https://reviews.apache.org/r/35486/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Successfully put a HOLDING upgrade into ABORTED and then resumed it with a PENDING request.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 35486: Upgrades Placed Into ABORTED Status Show As
COMPLETED
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35486/#review88052
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 15, 2015, 9:34 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35486/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 9:34 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11939
> https://issues.apache.org/jira/browse/AMBARI-11939
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When placing a stack upgrade request into the ABORTED state, Ambari calculates the stages and overall request as COMPLETED even though the tasks are actually ABORTED.
>
> This prevents that request from being placed back into the PENDING state.
>
> {code}
>
> - Now this upgrade can be aborted:
> {code:title=PUT api/v1/clusters/<cluster>/upgrades/21}
> {
> "Upgrade": {
> "request_status": "ABORTED"
> }
> }
> {code}
>
> - At this point, experimental mode can be enabled to work with Ambari. When finalize is ready, the same upgrade/request can be placed back into a {{PENDING}} status:
> {code:title=PUT api/v1/clusters/<cluster>/upgrades/21}
> {
> "Upgrade": {
> "request_status": "PENDING"
> }
> }
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 34fed41
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 79674cb
>
> Diff: https://reviews.apache.org/r/35486/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Successfully put a HOLDING upgrade into ABORTED and then resumed it with a PENDING request.
>
>
> Thanks,
>
> Jonathan Hurley
>
>