[jira] [Comment Edited] (SLING-4377) Add JSR305 annotations to Sling API

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301098#comment-14301098 ] 

Konrad Windszus edited comment on SLING-4377 at 2/2/15 10:07 AM:
-----------------------------------------------------------------

A WIP version is available at https://github.com/kwin/sling/compare/SLING-4377-jsr305?expand=1


was (Author: kwin):
I WIP version is available at https://github.com/kwin/sling/compare/SLING-4377-jsr305?expand=1

> Add JSR305 annotations to Sling API
> -----------------------------------
>
>                 Key: SLING-4377
>                 URL: https://issues.apache.org/jira/browse/SLING-4377
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>
> Since consumers of the Sling API always have to keep in mind whether a null-check is necessary it would be good to add JSR 305 annotations to the API.
> See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
> At least Eclipse as well as Findbugs are supporting those and Oak Solr is using those already (https://issues.apache.org/jira/browse/OAK-2303).
> Only the following 3 annotations should be used:
> # {{@Nonnull}}
> # {{@Nullable}}
> # {{@ParametersAreNonNullByDefault}}
> Those are the only ones being supported by both Eclipse and Findbugs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)