You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fortress@directory.apache.org by Shawn McKinney <sm...@apache.org> on 2017/07/13 02:04:55 UTC
Broken Build FC-221 add id to non temporal role constraint...
Chris, it looks like this commit broke the fortress core build:
https://github.com/apache/directory-fortress-core/commit/995073dacd41cb804eb94b57195d8e9a3de6d6ee
As evidenced by this jenkins test;
http://mail-archives.apache.org/mod_mbox/directory-notifications/201707.mbox/%3c24304792.10192.1499430533761.JavaMail.jenkins@crius%3e
I also verified locally by checking out the commit, running junit tests, getting the errors, checking out the previous commit, no errors.
Please let me know what you find out.
Thanks,
Shawn
Re: Broken Build FC-221 add id to non temporal role constraint...
Posted by Shawn McKinney <sm...@apache.org>.
Hey Chris,
thanks for the quick turnaround.
I am a bit concerned about those failures on your test instance.
If we can’t get that resolved, perhaps you can test using one of the docker images (what I do), or monitor the jenkins builds for breakage.
Shawn
> On Jul 13, 2017, at 8:15 AM, Chris Pike <cl...@psu.edu> wrote:
>
> Also, I do run the tests, there are just a number that fail because my openldap isn't configured correctly for user and password policy modifications, so I missed that these other ones were failing as well.
Re: Broken Build FC-221 add id to non temporal role constraint...
Posted by Chris Pike <cl...@psu.edu>.
Also, I do run the tests, there are just a number that fail because my openldap isn't configured correctly for user and password policy modifications, so I missed that these other ones were failing as well.
----- Original Message -----
From: "Chris Pike" <cl...@psu.edu>
To: "fortress" <fo...@directory.apache.org>
Sent: Thursday, July 13, 2017 8:45:32 AM
Subject: Re: Broken Build FC-221 add id to non temporal role constraint...
Yeah, I was actually removing a user from a role for one my tests. I added them back in, so this should be resolved now.
----- Original Message -----
From: "Emmanuel Lécharny" <el...@gmail.com>
To: fortress@directory.apache.org
Sent: Thursday, July 13, 2017 12:31:01 AM
Subject: Re: Broken Build FC-221 add id to non temporal role constraint...
Le 13/07/2017 à 04:04, Shawn McKinney a écrit :
> Chris, it looks like this commit broke the fortress core build:
>
> https://github.com/apache/directory-fortress-core/commit/995073dacd41cb804eb94b57195d8e9a3de6d6ee
>
> As evidenced by this jenkins test;
> http://mail-archives.apache.org/mod_mbox/directory-notifications/201707.mbox/%3c24304792.10192.1499430533761.JavaMail.jenkins@crius%3e
>
> I also verified locally by checking out the commit, running junit tests, getting the errors, checking out the previous commit, no errors.
>
> Please let me know what you find out.
That should be easy to fix : the test counts the number of role, so
adding one will break the check on this count.
--
Emmanuel Lecharny
Symas.com
directory.apache.org
Re: Broken Build FC-221 add id to non temporal role constraint...
Posted by Chris Pike <cl...@psu.edu>.
Yeah, I was actually removing a user from a role for one my tests. I added them back in, so this should be resolved now.
----- Original Message -----
From: "Emmanuel Lécharny" <el...@gmail.com>
To: fortress@directory.apache.org
Sent: Thursday, July 13, 2017 12:31:01 AM
Subject: Re: Broken Build FC-221 add id to non temporal role constraint...
Le 13/07/2017 à 04:04, Shawn McKinney a écrit :
> Chris, it looks like this commit broke the fortress core build:
>
> https://github.com/apache/directory-fortress-core/commit/995073dacd41cb804eb94b57195d8e9a3de6d6ee
>
> As evidenced by this jenkins test;
> http://mail-archives.apache.org/mod_mbox/directory-notifications/201707.mbox/%3c24304792.10192.1499430533761.JavaMail.jenkins@crius%3e
>
> I also verified locally by checking out the commit, running junit tests, getting the errors, checking out the previous commit, no errors.
>
> Please let me know what you find out.
That should be easy to fix : the test counts the number of role, so
adding one will break the check on this count.
--
Emmanuel Lecharny
Symas.com
directory.apache.org
Re: Broken Build FC-221 add id to non temporal role constraint...
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 13/07/2017 à 04:04, Shawn McKinney a écrit :
> Chris, it looks like this commit broke the fortress core build:
>
> https://github.com/apache/directory-fortress-core/commit/995073dacd41cb804eb94b57195d8e9a3de6d6ee
>
> As evidenced by this jenkins test;
> http://mail-archives.apache.org/mod_mbox/directory-notifications/201707.mbox/%3c24304792.10192.1499430533761.JavaMail.jenkins@crius%3e
>
> I also verified locally by checking out the commit, running junit tests, getting the errors, checking out the previous commit, no errors.
>
> Please let me know what you find out.
That should be easy to fix : the test counts the number of role, so
adding one will break the check on this count.
--
Emmanuel Lecharny
Symas.com
directory.apache.org