[GitHub] [fluo-muchos] ctubbsii commented on issue #334: Adds systemd support for accumulo services

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606369345
 
 
   > @ctubbsii Thanks for reviewing. I have made the changes you have suggested earlier. When you have some time can you please take a look again?
   
   Hi @ata18 ; I looked it over, and it looks like you incorporated most of my suggestions, except for the dash instead of underscore in the unit file names. However, it was a bit hard to tell what exactly changed, since you force pushed to your branch, and that marks all previous review comments as "Obsolete" and starts the review process over from scratch (GitHub won't show the diffs between updates, and the intermediate refs disappear from the repo, so it's hard to check them out manually for direct comparison on the command-line). In general, please avoid force-pushing when updating a PR after reviewers have commented. I can try to take a closer look at what changed tomorrow.
   
   I was curious if you had tested this in the single-tserver case and in the multiple tserver case.
   
   Also, I'm not sure I understand the need for the `accumulo-cluster-systemd` script. I was hoping to take a more thorough look at that when I had a chance. My first thought, though, is that it would be easier to run `pssh` for most things that script does than to try to adapt the `accumulo-cluster` script from Accumulo's out-of-box cluster management tool. Or, at the very least, a much simpler script based on `pssh` and `systemctl`. I'd have to take a deeper look into what the script is actually providing for Muchos, though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services