[GitHub] [airflow] jedcunningham commented on a change in pull request #21432: Add dev script to find core PRs missing categorization

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #21432:
URL: https://github.com/apache/airflow/pull/21432#discussion_r801996001



##########
File path: dev/airflow-github
##########
@@ -107,6 +109,71 @@ def is_pr(issue: Issue) -> bool:
     return "apache/airflow/pull/" in issue.html_url
 
 
+def files_touched(repo, commit_id: str) -> List[str]:
+    real_commit = repo.commit(commit_id)
+    return real_commit.stats.files.keys()
+
+
+def is_core_commit(files: List[str]) -> bool:
+    # We list out things that _aren't_ core files,
+    # and we want to know if the commit changes anything
+    # outside of these designated-non-core files
+
+    non_core_files = [

Review comment:
       Very true. Since this is excluding commits that only have changes in these files, new or moved things will pop into the list to be categorized, so at least it'll fail in a safe direction 👍




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org