You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/05/30 13:37:16 UTC
svn commit: r1832543 -
/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
Author: ggregory
Date: Wed May 30 13:37:16 2018
New Revision: 1832543
URL: http://svn.apache.org/viewvc?rev=1832543&view=rev
Log:
[CODEC-246] ColognePhoneticTest.testIsEncodeEquals missing assertions.
Modified:
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java?rev=1832543&r1=1832542&r2=1832543&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java (original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java Wed May 30 13:37:16 2018
@@ -136,6 +136,7 @@ public class ColognePhoneticTest extends
public void testIsEncodeEquals() {
//@formatter:off
final String[][] data = {
+ {"Muller", "M\u00fcller"}, // Müller
{"Meyer", "Mayr"},
{"house", "house"},
{"House", "house"},
@@ -149,22 +150,6 @@ public class ColognePhoneticTest extends
Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
}
}
-
- @Test
- @Ignore("https://issues.apache.org/jira/browse/CODEC-246")
- public void testIsEncodeEqualsCodec246() {
- //@formatter:off
- final String[][] data = {
- {"Meyer", "M\u00fcller"}, // Müller
- };
- //@formatter:on
- for (final String[] element : data) {
- // This just compares and only shows we do not blow up
- final boolean encodeEqual = this.getStringEncoder().isEncodeEqual(element[1], element[0]);
- // Fails for https://issues.apache.org/jira/browse/CODEC-246
- Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
- }
- }
@Test
public void testVariationsMella() throws EncoderException {