[jira] [Commented] (OFBIZ-3654) Returning "failure" from a shipment estimator has no impact on subsequent processing

["Taher Alkhateeb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965681#comment-14965681 ] 

Taher Alkhateeb commented on OFBIZ-3654:
----------------------------------------

I investigated this issue a little bit and found the below commit logs from Si Chen

{quote}
 r549561 | sichen | 2007-06-21 20:35:00 +0300 (Thu, 21 Jun 2007) | 1 line
 
 Fix a potential rollback crash if upsRateEstimateByPostalCode is called for an address with a missing zip code.  By returning failure instead of using service engine to     validate zip code, we avoid a rollback which could crash checkout screens
 ------------------------------------------------------------------------
 r547355 | sichen | 2007-06-14 21:50:30 +0300 (Thu, 14 Jun 2007) | 1 line
 
 Changed returnError to returnFailure in UPS rate inquire services, so failing to get a UPS rate doesn't crash your whole checkout process
{quote}

The whole order session design is problematic, so this JIRA should be closed and instead a redesign of the entire checkout session management problem is in order.

> Returning "failure" from a shipment estimator has no impact on subsequent processing
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3654
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3654
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Ean Schuessler
>
> The UPS processor includes a comment "Important: DO NOT returnError here or you could trigger a transaction rollback and break other services."  Returning a failure, however, is basically ignored and only causes the estimate to return a zero amount estimate. It should be possible to return a proper error message for further processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)