You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Vinayak Hegde (Jira)" <ji...@apache.org> on 2023/11/14 09:56:00 UTC

[jira] [Created] (YUNIKORN-2152) Move QueuePreemptionSnapshot type and tests to their own files

Vinayak Hegde created YUNIKORN-2152:
---------------------------------------

             Summary: Move QueuePreemptionSnapshot type and tests to their own files
                 Key: YUNIKORN-2152
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2152
             Project: Apache YuniKorn
          Issue Type: Improvement
          Components: core - scheduler
            Reporter: Vinayak Hegde
            Assignee: Vinayak Hegde


The QueuePreemptionSnapshot type should not be part of the preemption.go file.

All declarations and functions that have a QueuePreemptionSnapshot as receiver or return value value should be moved. Unused functions should be removed.

Unneeded exports on functions / types should be removed. If exported the comments on the functions and types need to comply with standard go rules.

All remaining functions should get tests to make sure they are working correctly.

Additionally, implement Stringer interface so that zap.Any() calls can be replaced with zap.Stringer() to avoid reflection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org