[jira] [Commented] (TC-258) setup_kabletown.pl needs to be updated

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987820#comment-15987820 ] 

ASF GitHub Bot commented on TC-258:
-----------------------------------

GitHub user dangogh opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/528

    [TC-258] Kabletown fixes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dangogh/incubator-trafficcontrol kabletown-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
    
----
commit 5b0a3c5d74b3dfaf1182abe673fe8c9293dd6645
Author: Dan Kirkwood <da...@gmail.com>
Date:   2017-04-27T21:56:22Z

    removes unused schema files

commit 2564ccd05c229944ea8c1c7852211ef2880599b2
Author: Dan Kirkwood <da...@gmail.com>
Date:   2017-04-27T22:15:25Z

    make params unique in fixtures by modifying values

commit 9678f801b1e7dec1f64623cd1486bd56bc09e39e
Author: Dan Kirkwood <da...@gmail.com>
Date:   2017-04-27T22:16:11Z

    use DBIx methods to get list of tables to delete; use truncate instead of delete_all

----


> setup_kabletown.pl needs to be updated
> --------------------------------------
>
>                 Key: TC-258
>                 URL: https://issues.apache.org/jira/browse/TC-258
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Ops
>    Affects Versions: 2.0.0
>            Reporter: Dan Kirkwood
>
> app/bin/db/setup_kabletown.pl loads data from app/lib/Fixtures (via lib/Test/IntegrationHelper.pm), but appears to be out of date.   Several issues:
> - sub teardown {} tries to delete all rows from a table,  but doesn't succeed many times with postgresql -- possibly because of foreign key constraints. Suggest using a TRUNCATE table CASCADE sql command rather than $resultset->delete_all
> - sub unload_core_data {} runs teardown on a bunch of tables, but doesn't list all of them.   May be leftover data.
> - new unique constraints are violated by parameter and profile_parameter data in the Fixtures.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)