[GitHub] [airflow] potiuk opened a new pull request, #27868: Fix templating fields and do_xcom_push in DatabricksSQLOperator

[GitBox <gi...@apache.org>]

potiuk opened a new pull request, #27868:
URL: https://github.com/apache/airflow/pull/27868

   When SQLExecuteQueryOperator has been introduced in #25717, it introduced some errors in the Databricks SQL operator:
   
   * The templated "schema" field has not been set as field in the operator.
   * The do_xcom_push parameter was ignored
   
   This PR fixes it by:
   
   * storing schema as field and using it via self reference
   * do_xcom_push is removed (and BaseOperator's one is used).
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #27868: Fix templating fields and do_xcom_push in DatabricksSQLOperator

[GitBox <gi...@apache.org>]

potiuk merged PR #27868:
URL: https://github.com/apache/airflow/pull/27868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27868: Fix templating fields and do_xcom_push in DatabricksSQLOperator

[GitBox <gi...@apache.org>]

potiuk commented on PR #27868:
URL: https://github.com/apache/airflow/pull/27868#issuecomment-1325653112

   cc: @vincbeck @alexott -> separated out just templating and do_xcom_push fixes from #27854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org