You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/04 09:33:37 UTC
[GitHub] [camel] Kinae opened a new pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Kinae opened a new pull request #5166:
URL: https://github.com/apache/camel/pull/5166
Endpoint can override the component option prefetchCount to allow more customisation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Kinae edited a comment on pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Posted by GitBox <gi...@apache.org>.
Kinae edited a comment on pull request #5166:
URL: https://github.com/apache/camel/pull/5166#issuecomment-790624159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Kinae commented on pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Posted by GitBox <gi...@apache.org>.
Kinae commented on pull request #5166:
URL: https://github.com/apache/camel/pull/5166#issuecomment-790624159
Thank you @davsclaus for the input, learning more and more about Apache Camel each day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Kinae commented on a change in pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Posted by GitBox <gi...@apache.org>.
Kinae commented on a change in pull request #5166:
URL: https://github.com/apache/camel/pull/5166#discussion_r587462292
##########
File path: components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
##########
@@ -154,6 +154,10 @@
@UriParam(defaultValue = "false", label = "advanced",
description = "Sets whether synchronous processing should be strictly used")
private boolean synchronous;
+ @UriParam(label = "consumer,advanced",
+ description = "Tell the broker how many messages to send in a single request. Often this can be set quite high to improve throughput."
+ + " This param override the value from the component.")
Review comment:
Thanks, will remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #5166:
URL: https://github.com/apache/camel/pull/5166#discussion_r587429815
##########
File path: components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQEndpoint.java
##########
@@ -154,6 +154,10 @@
@UriParam(defaultValue = "false", label = "advanced",
description = "Sets whether synchronous processing should be strictly used")
private boolean synchronous;
+ @UriParam(label = "consumer,advanced",
+ description = "Tell the broker how many messages to send in a single request. Often this can be set quite high to improve throughput."
+ + " This param override the value from the component.")
Review comment:
param -> parameter
But you do not have to tell this, its a common practice for Camel components where options can be configured as default on component level, and override per endpoint if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5166:
URL: https://github.com/apache/camel/pull/5166#issuecomment-790585811
You also need to change where the prefectCount is in use today.
1)
In component set the component level prefetc count on the endpoint createde like the other options are done
endpoint override is done later so you can specify a new value in uri and it will be in use instead of component level
2)
In some listener factory the prefect is in use, its taken from component today, but take it from endpoint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5166: CAMEL-16301 Allow endpoint to override prefetchCount from component
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5166:
URL: https://github.com/apache/camel/pull/5166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org