You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/03/31 14:54:27 UTC
[GitHub] [incubator-echarts] mayrhoferaski opened a new issue #12359:
Magictype Event
mayrhoferaski opened a new issue #12359: Magictype Event
URL: https://github.com/apache/incubator-echarts/issues/12359
### Version
4.7.0
### Reproduction link
[https://www.echartsjs.com/examples/en/editor.html?c=bar-animation-delay](https://www.echartsjs.com/examples/en/editor.html?c=bar-animation-delay)
### Steps to reproduce
1.) Go to Example
2.) Add this Code
myChart.on('magictypechanged',function(obj){
if (obj.currentType == "stack"){
alert("stack: " obj.currentType);
}else{
alert("tiled:" obj.currentType);
}
});
### What is expected?
toggle between stack and tiled
### What is actually happening?
currentType is always "stack"
---
I'm looking now for the stack word in the newOption.series[0].stack to be either "" or "__ec_magicType_stack__", but it should not be this way.
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #12359: Magictype
Event
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #12359: Magictype Event
URL: https://github.com/apache/incubator-echarts/issues/12359#issuecomment-606786194
I've tried to fix it, it seems working well. But in another case, if we specify the option `stack` for series(refer to [series-line.stack](https://www.echartsjs.com/en/option.html#series-line.stack)), does the stack icon in the toolbox need to be emphasized(selected) by default at the very first rendering. Any idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang closed issue #12359: Magictype Event
Posted by GitBox <gi...@apache.org>.
pissang closed issue #12359:
URL: https://github.com/apache/echarts/issues/12359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang closed issue #12359: Magictype Event
Posted by GitBox <gi...@apache.org>.
pissang closed issue #12359:
URL: https://github.com/apache/echarts/issues/12359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] alex2wong commented on issue #12359: Magictype
Event
Posted by GitBox <gi...@apache.org>.
alex2wong commented on issue #12359: Magictype Event
URL: https://github.com/apache/incubator-echarts/issues/12359#issuecomment-607301620
I suppose the stack icon should be emphasized if we set option stack for series at initial stage. The state should be synced between the series and the toolbox.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12359:
Magictype Event
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12359: Magictype Event
URL: https://github.com/apache/incubator-echarts/issues/12359#issuecomment-606678222
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] alex2wong commented on issue #12359: Magictype
Event
Posted by GitBox <gi...@apache.org>.
alex2wong commented on issue #12359: Magictype Event
URL: https://github.com/apache/incubator-echarts/issues/12359#issuecomment-607317783
Thanks for your investigation @plainheart ~ You can refer to previous key changes on this toolbox stack things.
To put it simply, at first we want to simplify the stack icon status, integrate two icons **into one toggle icon**. so I removed `tiled` type and keep only one stack icon.
The fisrt commit about this topic: https://github.com/apache/incubator-echarts/commit/e7af6731d048dff489d16e806eab6f5772d32c08
Then we made some revision, removed the tiled icon and type. https://github.com/apache/incubator-echarts/commit/780614906e19fa6a7c5072fcdae2635ad7ac7840
Maybe here we can do more things to make sure the `magictypechanged` event emit correct type, at the same time keep our enhancement months ago. @pissang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart edited a comment on issue #12359: Magictype Event
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #12359:
URL: https://github.com/apache/incubator-echarts/issues/12359#issuecomment-606786194
I've tried to fix it, it seems to be working well. But in another case, if we specify the option `stack` for series(refer to [series-line.stack](https://www.echartsjs.com/en/option.html#series-line.stack)), does the stack icon in the toolbox need to be emphasized(selected) by default at the very first rendering. Any idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] ishowman commented on issue #12359: Magictype Event
Posted by GitBox <gi...@apache.org>.
ishowman commented on issue #12359:
URL: https://github.com/apache/incubator-echarts/issues/12359#issuecomment-662790254
@alex2wong there is a linked pr awaiting review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org