You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/23 22:54:19 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #17797: Fix broken MSSQL test

jedcunningham commented on a change in pull request #17797:
URL: https://github.com/apache/airflow/pull/17797#discussion_r694361191



##########
File path: tests/task/task_runner/test_standard_task_runner.py
##########
@@ -228,6 +225,8 @@ def test_on_kill(self):
         for process in processes:
             assert not psutil.pid_exists(process.pid), f"{process} is still alive"
 
+        session.close()

Review comment:
       I can convert this to `createSession` which would do that, but calling `close` like this is pretty common in our test suite.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org