[GitHub] crmo commented on a change in pull request #450: UIWebView call loadRequest multiple times lead to deadlock in iOS12 (fixes #447)

[GitBox <gi...@apache.org>]

crmo commented on a change in pull request #450: UIWebView call loadRequest multiple times lead to deadlock in iOS12 (fixes #447)
URL: https://github.com/apache/cordova-ios/pull/450#discussion_r246626749
 
 

 ##########
 File path: CordovaLib/Classes/Private/Plugins/CDVUIWebViewEngine/CDVUIWebViewDelegate.m
 ##########
 @@ -329,9 +329,14 @@ - (void)webViewDidFinishLoad:(UIWebView*)webView
             break;
 
         case STATE_WAITING_FOR_LOAD_FINISH:
-            if (_loadCount == 1) {
+            // fix call loadRequest multiple times just callback webViewDidFinishLoad once time in iOS 12
+            if (@available(iOS 12.0, *)) {
 
 Review comment:
   I test for iOS 12.1 (Xcode Version 10.1 (10B61)),this problem has not been reproduced.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org