[GitHub] [incubator-echarts] pissang commented on a change in pull request #12550: feat(dataZoom): custom brush style in toolbox.feature.dataZoom

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #12550:
URL: https://github.com/apache/incubator-echarts/pull/12550#discussion_r464943332



##########
File path: src/component/toolbox/feature/DataZoom.js
##########
@@ -236,16 +240,30 @@ function updateZoomBtnStatus(featureModel, ecModel, view, payload, api) {
             zoomActive
             ? {
                 brushType: 'auto',
-                brushStyle: {
-                    // FIXME user customized?
-                    lineWidth: 0,
-                    fill: 'rgba(0,0,0,0.2)'
-                }
+                brushStyle: mapBrushStyle(featureModel.option.brushStyle)
             }

Review comment:
       Model has provided a `getItemStyle` method to map all the style properties.
   
   ```js
   brushStyle: featureModel.getModel('brushStyle').getItemStyle()
   ```
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org