You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2019/09/30 18:29:38 UTC

[GitHub] [aurora] rdelval opened a new pull request #87: Allow configuration manager to accept non-prod jos with SLAPolicy

rdelval opened a new pull request #87: Allow configuration manager to accept non-prod jos with SLAPolicy
URL: https://github.com/apache/aurora/pull/87
 
 
   ### Description:
   
   Missed this on the original patch to enable SLA aware killing for non-prod jobs.
   
   Currently the flag that enable non-production jobs to be drained with an SLA policy does not also allow jobs that are non production to have an SLA Policy object attached to them.
   
   This patch modifies ConfigurationManager to allow non-production jobs to have an SLA policy attached to them.
   
   Added a unit test to make sure the flag is working as expected.
   
   ### Testing Done:
   
   * End to end
   * Unit testing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services