You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Filip Hanik - Dev Lists <de...@hanik.com> on 2007/10/19 17:21:22 UTC
[LOBBYING] Add nio connector to configuration validation
Ok, sending a little email to lobby for a useful change. To the contrary
of comments and vetoes to this change, it doesn't change existing
behavior, it simplifies it, and also adds the NIO connector to the
validation of server.xml attributes.
It'd be nice to get one more vote, so that we can get it in before the tag.
From STATUS
* Make server.xml parsing warnings more generic, add support for the NIO
connector
* Connector is no longer an exception case. Any new component can still
use setProperty and return a boolean
* to accept or reject the property
http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [LOBBYING] Add nio connector to configuration validation
Posted by Paul Shemansky <pa...@gmail.com>.
For what it's worth :)
+1
On 10/19/07, Filip Hanik - Dev Lists <de...@hanik.com> wrote:
> Ok, sending a little email to lobby for a useful change. To the contrary
> of comments and vetoes to this change, it doesn't change existing
> behavior, it simplifies it, and also adds the NIO connector to the
> validation of server.xml attributes.
>
> It'd be nice to get one more vote, so that we can get it in before the tag.
>
> From STATUS
> * Make server.xml parsing warnings more generic, add support for the NIO
> connector
> * Connector is no longer an exception case. Any new component can still
> use setProperty and return a boolean
> * to accept or reject the property
> http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
>
>
> Filip
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [LOBBYING] Add nio connector to configuration validation
Posted by Tim Funk <fu...@joedog.org>.
For java/org/apache/coyote/http11/Http11NioProtocol.java
Is it me or does this look odd after the patch (as well as before) ...
public void setProperty(String name, String value) {
setAttribute(name, value);
if (/*omitted for word wrap since it doesn't matter */) {
return ep.setProperty(name, value);
} else {
return ep.setProperty(name, value); /*commit omitted for ww*/
}
}
Should this be simplified too:
public void setProperty(String name, String value) {
setAttribute(name, value);
return ep.setProperty(name, value);
}
-Tim
Filip Hanik - Dev Lists wrote:
> Ok, sending a little email to lobby for a useful change. To the contrary
> of comments and vetoes to this change, it doesn't change existing
> behavior, it simplifies it, and also adds the NIO connector to the
> validation of server.xml attributes.
>
> It'd be nice to get one more vote, so that we can get it in before the tag.
>
> From STATUS
> * Make server.xml parsing warnings more generic, add support for the NIO
> connector
> * Connector is no longer an exception case. Any new component can still
> use setProperty and return a boolean
> * to accept or reject the property
> http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [LOBBYING] Add nio connector to configuration validation
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Costin Manolache wrote:
> -0
>
this isn't a new proposal, the implementation has already been done.
this is just completing it.
we'd have to go back to when the implementation was done to start
changing it, that's not what I'm doing.
Filip
> The setProperty was done way before JMX, and it's quite hacky. I think
> standardising on JMX-like model is better - i.e. if we make changes to
> setProperty and connector configuration, it should bring it closer to JMX.
>
> In JMX we have a "void setAttribute(...) throws AttributeNotFound", plus a
> method to get supported attribute names.
>
> So instead of returning the boolean - I think it would be better to add a
> method to list supported attributes ( and with some changes to modeler this
> could be reflected in the mbean - right now setProperty is ignored ). It's a
> bit more complicated - but also more valuable.
>
> Costin
> -0
>
> On 10/19/07, Filip Hanik - Dev Lists <de...@hanik.com> wrote:
>
>> Ok, sending a little email to lobby for a useful change. To the contrary
>> of comments and vetoes to this change, it doesn't change existing
>> behavior, it simplifies it, and also adds the NIO connector to the
>> validation of server.xml attributes.
>>
>> It'd be nice to get one more vote, so that we can get it in before the
>> tag.
>>
>> From STATUS
>> * Make server.xml parsing warnings more generic, add support for the NIO
>> connector
>> * Connector is no longer an exception case. Any new component can still
>> use setProperty and return a boolean
>> * to accept or reject the property
>>
>> http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
>>
>>
>> Filip
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>
>
> ------------------------------------------------------------------------
>
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.488 / Virus Database: 269.15.3/1081 - Release Date: 10/19/2007 5:41 PM
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [LOBBYING] Add nio connector to configuration validation
Posted by Costin Manolache <co...@gmail.com>.
-0
The setProperty was done way before JMX, and it's quite hacky. I think
standardising on JMX-like model is better - i.e. if we make changes to
setProperty and connector configuration, it should bring it closer to JMX.
In JMX we have a "void setAttribute(...) throws AttributeNotFound", plus a
method to get supported attribute names.
So instead of returning the boolean - I think it would be better to add a
method to list supported attributes ( and with some changes to modeler this
could be reflected in the mbean - right now setProperty is ignored ). It's a
bit more complicated - but also more valuable.
Costin
-0
On 10/19/07, Filip Hanik - Dev Lists <de...@hanik.com> wrote:
>
> Ok, sending a little email to lobby for a useful change. To the contrary
> of comments and vetoes to this change, it doesn't change existing
> behavior, it simplifies it, and also adds the NIO connector to the
> validation of server.xml attributes.
>
> It'd be nice to get one more vote, so that we can get it in before the
> tag.
>
> From STATUS
> * Make server.xml parsing warnings more generic, add support for the NIO
> connector
> * Connector is no longer an exception case. Any new component can still
> use setProperty and return a boolean
> * to accept or reject the property
>
> http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
>
>
> Filip
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>