You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by bh...@apache.org on 2019/05/27 21:40:58 UTC

[hadoop] branch trunk updated: HDDS-1598. Fix Ozone checkstyle issues on trunk. Contributed by Elek, Marton. (#854)

This is an automated email from the ASF dual-hosted git repository.

bharat pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new ec92ca6  HDDS-1598. Fix Ozone checkstyle issues on trunk. Contributed by Elek, Marton. (#854)
ec92ca6 is described below

commit ec92ca6575e0074ed4983fa8b34324bdbeb23499
Author: Elek, Márton <el...@users.noreply.github.com>
AuthorDate: Mon May 27 23:40:51 2019 +0200

    HDDS-1598. Fix Ozone checkstyle issues on trunk. Contributed by Elek, Marton. (#854)
---
 .../placement/algorithms/SCMContainerPlacementRackAware.java          | 4 ++--
 .../placement/algorithms/TestSCMContainerPlacementRackAware.java      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java
index 3758b85..ffebb84 100644
--- a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java
+++ b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java
@@ -51,8 +51,8 @@ public final class SCMContainerPlacementRackAware extends SCMCommonPolicy {
       LoggerFactory.getLogger(SCMContainerPlacementRackAware.class);
   private final NetworkTopology networkTopology;
   private boolean fallback;
-  private int RACK_LEVEL = 1;
-  private int MAX_RETRY= 3;
+  private static final int RACK_LEVEL = 1;
+  private static final int MAX_RETRY= 3;
 
   /**
    * Constructs a Container Placement with rack awareness.
diff --git a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
index d80c7e5..732178e 100644
--- a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
+++ b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
@@ -53,7 +53,7 @@ public class TestSCMContainerPlacementRackAware {
   // policy prohibit fallback
   private SCMContainerPlacementRackAware policyNoFallback;
   // node storage capacity
-  private final long STORAGE_CAPACITY = 100L;
+  private static final long STORAGE_CAPACITY = 100L;
 
   @Before
   public void setup() {


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org