You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/26 19:19:37 UTC
[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3999
[FLINK-6720] Activate strict checkstyle in flink-java8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6720_cs_j8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3999.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3999
----
commit 0bb68669890b5e8e574fb4b1635a36c3f8135dc8
Author: zentol <ch...@apache.org>
Date: 2017-05-26T06:45:36Z
[FLINK-6720] Activate strict checkstyle in flink-java8
commit a847b3ab73a8277955e1dccad2a750df5b9696fc
Author: zentol <ch...@apache.org>
Date: 2017-05-26T07:22:44Z
[FLINK-6720] Rename java8 javaApiOperators package to api.java.operators
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3999
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3999: [FLINK-6720] Activate strict checkstyle in flink-java8
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3999
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3999#discussion_r118787991
--- Diff: flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java ---
@@ -33,23 +33,31 @@
import java.util.List;
import java.util.Map;
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+/**
+ * Tests for lambda support in CEP.
+ */
public class CEPLambdaTest extends TestLogger {
+ /**
+ * Test event class.
+ */
public static class EventA {}
+ /**
+ * Test even class.
--- End diff --
"even" -> "event"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3999: [FLINK-6720] Activate strict checkstyle in flink-java8
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3999
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3999#discussion_r118791491
--- Diff: flink-java8/src/test/java/org/apache/flink/test/api/java/operators/lambdas/FilterITCase.java ---
@@ -35,27 +38,38 @@
public static DataSet<Tuple3<Integer, Long, String>> get3TupleDataSet(ExecutionEnvironment env) {
List<Tuple3<Integer, Long, String>> data = new ArrayList<Tuple3<Integer, Long, String>>();
- data.add(new Tuple3<Integer, Long, String>(1,1l,"Hi"));
- data.add(new Tuple3<Integer, Long, String>(2,2l,"Hello"));
- data.add(new Tuple3<Integer, Long, String>(3,2l,"Hello world"));
- data.add(new Tuple3<Integer, Long, String>(4,3l,"Hello world, how are you?"));
- data.add(new Tuple3<Integer, Long, String>(5,3l,"I am fine."));
- data.add(new Tuple3<Integer, Long, String>(6,3l,"Luke Skywalker"));
- data.add(new Tuple3<Integer, Long, String>(7,4l,"Comment#1"));
- data.add(new Tuple3<Integer, Long, String>(8,4l,"Comment#2"));
- data.add(new Tuple3<Integer, Long, String>(9,4l,"Comment#3"));
- data.add(new Tuple3<Integer, Long, String>(10,4l,"Comment#4"));
- data.add(new Tuple3<Integer, Long, String>(11,5l,"Comment#5"));
- data.add(new Tuple3<Integer, Long, String>(12,5l,"Comment#6"));
- data.add(new Tuple3<Integer, Long, String>(13,5l,"Comment#7"));
- data.add(new Tuple3<Integer, Long, String>(14,5l,"Comment#8"));
- data.add(new Tuple3<Integer, Long, String>(15,5l,"Comment#9"));
- data.add(new Tuple3<Integer, Long, String>(16,6l,"Comment#10"));
- data.add(new Tuple3<Integer, Long, String>(17,6l,"Comment#11"));
- data.add(new Tuple3<Integer, Long, String>(18,6l,"Comment#12"));
- data.add(new Tuple3<Integer, Long, String>(19,6l,"Comment#13"));
- data.add(new Tuple3<Integer, Long, String>(20,6l,"Comment#14"));
- data.add(new Tuple3<Integer, Long, String>(21,6l,"Comment#15"));
+ data.add(new Tuple3<>(1, 1L, "Hi"));
+ data.add(new Tuple3<>(2, 2L, "Hello"));
+ data.add(new Tuple3<>(3, 2L, "Hello world"));
+ data.add(new Tuple3<>(4, 3L, "Hello world, how are you?"));
+ data.add(new Tuple3<>(5, 3L, "I am fine."));
+ data.add(new Tuple3<>(6, 3L, "Luke Skywalker"));
+ data.add(new Tuple3<>(7, 4L, "Comment#1"));
+ data.add(new Tuple3<>(8, 4L, "Comment#2"));
+ data.add(new Tuple3<>(9, 4L,
--- End diff --
Formatting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3999#discussion_r118790423
--- Diff: flink-java8/src/test/java/org/apache/flink/test/api/java/operators/lambdas/FilterITCase.java ---
@@ -35,27 +38,38 @@
public static DataSet<Tuple3<Integer, Long, String>> get3TupleDataSet(ExecutionEnvironment env) {
List<Tuple3<Integer, Long, String>> data = new ArrayList<Tuple3<Integer, Long, String>>();
- data.add(new Tuple3<Integer, Long, String>(1,1l,"Hi"));
- data.add(new Tuple3<Integer, Long, String>(2,2l,"Hello"));
- data.add(new Tuple3<Integer, Long, String>(3,2l,"Hello world"));
- data.add(new Tuple3<Integer, Long, String>(4,3l,"Hello world, how are you?"));
- data.add(new Tuple3<Integer, Long, String>(5,3l,"I am fine."));
- data.add(new Tuple3<Integer, Long, String>(6,3l,"Luke Skywalker"));
- data.add(new Tuple3<Integer, Long, String>(7,4l,"Comment#1"));
- data.add(new Tuple3<Integer, Long, String>(8,4l,"Comment#2"));
- data.add(new Tuple3<Integer, Long, String>(9,4l,"Comment#3"));
- data.add(new Tuple3<Integer, Long, String>(10,4l,"Comment#4"));
- data.add(new Tuple3<Integer, Long, String>(11,5l,"Comment#5"));
- data.add(new Tuple3<Integer, Long, String>(12,5l,"Comment#6"));
- data.add(new Tuple3<Integer, Long, String>(13,5l,"Comment#7"));
- data.add(new Tuple3<Integer, Long, String>(14,5l,"Comment#8"));
- data.add(new Tuple3<Integer, Long, String>(15,5l,"Comment#9"));
- data.add(new Tuple3<Integer, Long, String>(16,6l,"Comment#10"));
- data.add(new Tuple3<Integer, Long, String>(17,6l,"Comment#11"));
- data.add(new Tuple3<Integer, Long, String>(18,6l,"Comment#12"));
- data.add(new Tuple3<Integer, Long, String>(19,6l,"Comment#13"));
- data.add(new Tuple3<Integer, Long, String>(20,6l,"Comment#14"));
- data.add(new Tuple3<Integer, Long, String>(21,6l,"Comment#15"));
+ data.add(new Tuple3<>(1, 1L, "Hi"));
+ data.add(new Tuple3<>(2, 2L, "Hello"));
+ data.add(new Tuple3<>(3, 2L, "Hello world"));
+ data.add(new Tuple3<>(4, 3L, "Hello world, how are you?"));
+ data.add(new Tuple3<>(5, 3L, "I am fine."));
+ data.add(new Tuple3<>(6, 3L, "Luke Skywalker"));
+ data.add(new Tuple3<>(7, 4L, "Comment#1"));
+ data.add(new Tuple3<>(8, 4L, "Comment#2"));
+ data.add(new Tuple3<>(9, 4L,
+ "Comment#3"));
+ data.add(new Tuple3<>(10, 4L
--- End diff --
fix line breaks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3999: [FLINK-6720] Activate strict checkstyle in flink-java8
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3999
@greghogan should be fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---